Date: Wed, 6 Mar 2002 00:52:25 -0800 From: "David O'Brien" <obrien@freebsd.org> To: Mike Meyer <mwm-dated-1015831171.a21ab0@mired.org> Cc: Giorgos Keramidas <keramida@freebsd.org>, hackers@freebsd.org Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Message-ID: <20020306005225.A6921@dragon.nuxi.com> In-Reply-To: <15493.49923.458997.98416@guru.mired.org>; from mwm-dated-1015831171.a21ab0@mired.org on Wed, Mar 06, 2002 at 01:19:31AM -0600 References: <20020305201350.GC4820@hades.hell.gr> <20020305155850.A38095@dragon.nuxi.com> <20020306000806.GC6839@hades.hell.gr> <20020305164054.B38095@dragon.nuxi.com> <15493.49923.458997.98416@guru.mired.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 06, 2002 at 01:19:31AM -0600, Mike Meyer wrote: > David O'Brien <obrien@freebsd.org> types: > > On Wed, Mar 06, 2002 at 02:08:07AM +0200, Giorgos Jeremiahs wrote: > > I was giving one. :-) > > style(9) documents the practices of /sys. Thus we should not arbitaryly > > add rules w/o them being backed up in code. > > As the original author of the PR, I'll point out that this chagne does > *not* add rules. It clarifies the wording of a rule that's already > there. If the rule is wrong, it should be removed. The reason I didn't > post if for wider review was because it wasn't changing any rules. My > thanks to Giorgos for moving this PR towards closure. I don't think it is clarifying a rule. I think it is in fact adding a rule. You are extrapolating too much I think. All the rule is trying to prevent is "if (!strcmp(a,b))" which when read is extremely wrong of that is actually happening. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020306005225.A6921>