Date: Mon, 22 Apr 2002 18:06:52 -0400 From: Mike Barcroft <mike@FreeBSD.ORG> To: "David O'Brien" <obrien@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/ldd ldd.c sods.c Message-ID: <20020422180652.A72727@espresso.q9media.com> In-Reply-To: <20020422111856.B49799@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Mon, Apr 22, 2002 at 11:18:56AM -0700 References: <200204202009.g3KK9Uh55665@freefall.freebsd.org> <20020422111856.B49799@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien <obrien@FreeBSD.ORG> writes: > On Sat, Apr 20, 2002 at 01:09:29PM -0700, Mike Barcroft wrote: > > mike 2002/04/20 13:09:29 PDT > > > > Modified files: > > usr.bin/ldd ldd.c sods.c > > Log: > > Include <arpa/inet.h> for prototype of ntohl() used in the N_BADMAG() > > macro. > > This seems very silly -- 'ldd' has zero to do with networking. Perhaps > ntohl really needs to be moved to another header, which apra/inet.h > includes. Then why is it using Network to host conversion macros? The Standard defines these macros in <arpa/inet.h> and <netinet/in.h>. We used to leak them all over the place (<sys/types.h> for instance), which is why this is a new warning. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020422180652.A72727>