Date: Mon, 26 Aug 2002 09:24:23 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Joerg Wunsch <j@uriah.heep.sax.de>, Kris Kennaway <kris@obsecurity.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/cad/spice/files patch-bc Message-ID: <20020826162423.GD55409@xor.obsecurity.org> In-Reply-To: <20020826103637.A54956@uriah.heep.sax.de> References: <200208251900.g7PJ0bTA043526@freefall.freebsd.org> <20020825210354.GA40085@xor.obsecurity.org> <20020826103637.A54956@uriah.heep.sax.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--2iBwrppp/7QCDedR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 26, 2002 at 10:36:37AM +0200, Joerg Wunsch wrote: > As Kris Kennaway wrote: >=20 > > > When destroying a graph, don't attempt to dereference the contents = of > > > already free()d client_data. Instead, extract the widget to destroy > > > first, then destroy the client_data, then destroy the remembered > > > widget. > > > =20 > > > The maintainer of this port never responsed to my emails. > >=20 > > PORTREVISION bump? >=20 > If i read the porter's handbook correctly, a PORTREVISION bump is not > warranted. Both my changes fall under the category of making the > program compile & run on -current (or other malloc AJ systems) at all, > without changing the structure of the resulting package. I. e., users > that could use the program without problems in the past don't > necessarily need to upgrade. What about the users who have installed the port, but haven't been able to run it because it keeps crashing on them? They want to upgrade to the new version, because you have fixed the bugs. I think a PORTREVISION bump is warranted in this instance. Kris --2iBwrppp/7QCDedR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9alY2Wry0BWjoQKURAoobAKD94i6EQjRmuxkHzhoOZIWSWjZwbQCeMD+/ 1y2+7tyurC+wuB8DocQhld8= =pfeq -----END PGP SIGNATURE----- --2iBwrppp/7QCDedR-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020826162423.GD55409>