Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 02 Oct 2002 08:41:10 +0900 (JST)
From:      Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
To:        jhb@FreeBSD.ORG
Cc:        mmcgoldrick@linuxdriven.net, current@FreeBSD.ORG
Subject:   Re: PCI brokenness
Message-ID:  <20021002.084110.69705085.iwasaki@jp.FreeBSD.org>
In-Reply-To: <XFMail.20021001172334.jhb@FreeBSD.org>
References:  <20021001211543.GA607@uriel.fakedomain.net> <XFMail.20021001172334.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

> On 01-Oct-2002 Michael McGoldrick wrote:
> > On Tue, Oct 01, 2002 at 12:48:47PM -0400, John Baldwin wrote:
> >> 
> >> On 01-Oct-2002 Michael McGoldrick wrote:
> >> > 'Me too'
> >> > Dmesg from working kernel attached, not sure how to get a dmesg from the
> >> > broken one. :(
> >> > Send me a mail if any further info would help.
> >> > (I have built two kernels recently, both have had this problem)
> >> 
> >> What exact problem do you have.  No PCI devices?
> >> 
> >> -- 
> >> 
> >> John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
> >> "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
> >> 
> >> To Unsubscribe: send mail to majordomo@FreeBSD.org
> >> with "unsubscribe freebsd-current" in the body of the message
> > 
> > Yes, the kernel seems to attempt to mount root right after this line:
> > device_probe_and_attach: acpi0 attach returned 6
> 
> Can you try with the stuff I committed yesterday?  It fixed the case (for
> my tests at least) of legacy0 failing to attach or probe when acpi failed
> to attach.

If still failed, please try this.
I've noticed that no chance to call pci_cfgregopen() before probing
PCI children in case Host PCI bridge _CRS is not method or _INI method
don't access to PCI config space or something.

Thanks

Index: acpi_pcib_acpi.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_acpi.c,v
retrieving revision 1.23
diff -u -r1.23 acpi_pcib_acpi.c
--- acpi_pcib_acpi.c	26 Aug 2002 18:30:27 -0000	1.23
+++ acpi_pcib_acpi.c	1 Oct 2002 23:17:51 -0000
@@ -114,6 +115,9 @@
 	!acpi_disabled("pci") &&
 	acpi_MatchHid(dev, "PNP0A03")) {
 
+	if (!pci_cfgregopen())
+		return(ENXIO);
+
 	/*
 	 * Set device description 
 	 */
Index: acpi_pcib_pci.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_pci.c,v
retrieving revision 1.1
diff -u -r1.1 acpi_pcib_pci.c
--- acpi_pcib_pci.c	26 Aug 2002 18:30:27 -0000	1.1
+++ acpi_pcib_pci.c	1 Oct 2002 23:18:38 -0000
@@ -114,6 +115,9 @@
 	return (ENXIO);
     if (acpi_get_handle(dev) == NULL)
 	return (ENXIO);
+    if (!pci_cfgregopen())
+	return (ENXIO);
+
     device_set_desc(dev, "ACPI PCI-PCI bridge");
     return (-1000);
 }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021002.084110.69705085.iwasaki>