Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Nov 2002 08:19:35 -0800 (PST)
From:      Archie Cobbs <archie@dellroad.org>
To:        Harti Brandt <brandt@fokus.gmd.de>
Cc:        Iasen Kostov <ikostov@otel.net>, Archie Cobbs <archie@dellroad.org>, freebsd-net@FreeBSD.org
Subject:   Re: NFS functions does *NOT* check if they really have allocated any memory
Message-ID:  <200211061619.gA6GJZ93002593@arch20m.dellroad.org>
In-Reply-To: <20021106125444.K20974-100000@beagle.fokus.gmd.de> "from Harti Brandt at Nov 6, 2002 12:56:13 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
Harti Brandt writes:
> IK>> >   As I experience system crushes at time of mbufs exhaustion I've compiled
> IK>> > a debug kernel and traced the problem. I seems the NFS functions
> IK>> > (nfsm_rpchead, nfsm_reqh ...) does *NOT* chek if they really have
> IK>> > allocated memory by MGET macro.
> IK>>
> IK>> No check is necessary if M_WAIT is specified; the M_GET() function
> IK>> is always successful in that case. Same for malloc().
> 
> Wrong. malloc() returns always successful with M_WAIT, M_GET not. There
> is a timeout the M_GET() will wait, but the it will return NULL.

Oops, you're right.. sorry for the misinformation.

Sounds like a bug to me (did Iasen file a PR?)

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211061619.gA6GJZ93002593>