Date: Mon, 3 Feb 2003 12:10:26 -0800 From: Gordon Tetlow <gordont@gnf.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: phk@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom geom_vol_ffs.c Message-ID: <20030203201026.GD98559@roark.gnf.org> In-Reply-To: <xzphebl6t4p.fsf@flood.ping.uio.no> References: <11633.1044300113@critter.freebsd.dk> <xzphebl6t4p.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--VMt1DrMGOVs3KQwf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 03, 2003 at 08:50:30PM +0100, Dag-Erling Smorgrav wrote: > A couple of comments to vol_ffs: >=20 > - I had to reboot for the volume names to actually appear in /dev/vol. >=20 > - I was unable to set a volume name on my root partition. I tried > 'tunefs -L root /dev/ad0a' in single-user mode, before mounting > anything. It did not show up in /dev/vol, even after a reboot. This is because you opened another device underneath the volume name device. This causes a spoil event to kill the volume name device. If you were to put /dev/vol/rootfs in your fstab, it'll work but it takes some faith. I had the same experience on my laptop. > - Although tunefs(8) won't let you set a volume label containing > anything but alphanumerics (IMHO, it should accept underscores as > well), there's nothing in g_vol_ffs_taste() that checks for invalid > characters in the label. What happens if I manually edit the > superblock and put a / in there? (imagine inserting a borrowed Zip > disk and boom...) I've got a commit in my tree that adds a comment about this. It's on my TODO list. I was thinking of adding . as a valid character as well (but disallowing leading periods for security reasons). -gordon --VMt1DrMGOVs3KQwf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+PsyyRu2t9DV9ZfsRAuxVAKCVKTxUkj8RCTspHlOSBvLzvI4EmACgusFz vqpcrEkpzLu6OfZys5CoxhY= =Tz6c -----END PGP SIGNATURE----- --VMt1DrMGOVs3KQwf-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030203201026.GD98559>