Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Jan 2004 12:28:34 +0200
From:      Ruslan Ermilov <ru@freebsd.org>
To:        Colin Percival <colin.percival@wadham.ox.ac.uk>
Cc:        stable@freebsd.org
Subject:   Re: Fix make release for 4-STABLE
Message-ID:  <20040119102834.GD41159@FreeBSD.org.ua>
In-Reply-To: <6.0.1.1.1.20040119094517.04743ea8@imap.sfu.ca>
References:  <20040118141444.GG51708@sirius.firepipe.net> <20040118235148M.matusita@jp.FreeBSD.org> <20040119092819.GA41159@FreeBSD.org.ua> <6.0.1.1.1.20040119094517.04743ea8@imap.sfu.ca>

next in thread | previous in thread | raw e-mail | index | archive | help

--JwB53PgKC5A7+0Ej
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 19, 2004 at 09:47:45AM +0000, Colin Percival wrote:
> At 09:28 19/01/2004, Ruslan Ermilov wrote:
> >Maybe it's time for drivers.flp to appear on RELENG_4?  If someone
> >could MFC the support to sysinstall, I could help with release/
> >bits.
>=20
>   I've already mentioned this to re@, but if there's a real need
> for space-saving, using NetBSD's makefs (ports/sysutils/makefs)
>=20
Cool!  At a glance it looks like what we need to fully support
cross-arch releases, as it supports different byte-ordering.

It could also be used to get us closer to "fixing" release/ to not
require "root" privileges -- it could be a very useful feature for
developers with non-root access on fast machine.  ;)

> saves about 23k on the mfsroot floppy.
>=20
I wonder if this 23k difference is on 5-CURRENT or 4-STABLE, or both?
If it is on 5-CURRENT only, does the following patch for FreeBSD's
newfs(8) make any difference:

%%%
Index: mkfs.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sbin/newfs/mkfs.c,v
retrieving revision 1.83
diff -u -r1.83 mkfs.c
--- mkfs.c	27 Nov 2003 01:19:23 -0000	1.83
+++ mkfs.c	28 Nov 2003 09:33:11 -0000
@@ -324,7 +324,7 @@
 	for ( ; sblock.fs_fpg < maxblkspercg; sblock.fs_fpg +=3D sblock.fs_frag) {
 		sblock.fs_ipg =3D roundup(howmany(sblock.fs_fpg, fragsperinode),
 		    INOPB(&sblock));
-		if (sblock.fs_size / sblock.fs_fpg < MINCYLGRPS)
+		if (sblock.fs_size / sblock.fs_fpg < (Oflag =3D=3D 2 ? MINCYLGRPS : 1))
 			break;
 		if (CGSIZE(&sblock) < (unsigned long)sblock.fs_bsize)
 			continue;
%%%

If you don't bite me, I will try it myself.  ;)

Also, it would be nice to backport it to FreeBSD.  And I suspect
it doesn't work with UFS2, does it?  (We don't need it for releases
presently, but anyway.)


Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org

--JwB53PgKC5A7+0Ej
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAC7FSUkv4P6juNwoRAkZwAJ4kV2wUpFnhuBXFt9iepH5ApLoW6wCfZ7gx
jW+9kqHxZgwUIL+mMexNEjo=
=gxHx
-----END PGP SIGNATURE-----

--JwB53PgKC5A7+0Ej--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040119102834.GD41159>