Date: Fri, 23 Jan 2004 12:39:24 +0000 From: Matthew Seaman <m.seaman@infracaninophile.co.uk> To: Sepherosa Ziehau <sepherosa@SoftHome.net> Cc: ports@freebsd.org Subject: Re: FreeBSD Port: jfreechart-0.9.13 Message-ID: <20040123123924.GA49081@happy-idiot-talk.infracaninophile.co.uk> In-Reply-To: <opr177g61vt45q1u@mail.SoftHome.net> References: <opr177g61vt45q1u@mail.SoftHome.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--envbJBWh7q8WU6mo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Jan 23, 2004 at 07:28:08PM +0800, Sepherosa Ziehau wrote:
> without a java document, a java library is useless. I have upgraded=20
> jfreechart to 0.9.16 and add javadoc support.
> Hope somebody can review it and commit it for me.
Nice work. However, I can see a couple of problems with your patch.
You're building javadocs with one of a number of possible JDKs, and
that has the unfortunate consequence that the plist for the generated
Javadocs is different for different JDK versions. You're also using
ant(1) to do the build, which overrides the settings obtained by
USE_JAVA=3Dx.y and instead uses whatever the default JDK on the system
is. (Normally those JDKs will be the same, but not always.)
You can easily solve the pkg-plist problem by use of the PORTDOCS make
variable -- which also has the handy side effect of keeping the
pkg-plist file for the port nice and short. See the
databases/mysql-connector-java port I maintain for an example.
You can (if you think it's necessary) solve the ant(1) version problem
by:
ANT=3D ${SETENV} JAVA_HOME=3D${JAVA_HOME} ant
You also need a BUILD_DEPENDS on the devel/apache-ant port.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil. 26 The Paddocks
Savill Way
PGP: http://www.infracaninophile.co.uk/pgpkey Marlow
Tel: +44 1628 476614 Bucks., SL7 1TH UK
--envbJBWh7q8WU6mo
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAERX8dtESqEQa7a0RAgEJAJ9eN5MKvEi2ZUgOljyzyrrzagaFIwCfQZ0l
808S2EWTWDEJGd3qlq09Njs=
=lGNq
-----END PGP SIGNATURE-----
--envbJBWh7q8WU6mo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040123123924.GA49081>