Date: Tue, 30 Mar 2004 13:32:51 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: "Jacob S. Barrett" <jbarrett@amduat.net> Cc: freebsd-net@freebsd.org Subject: Re: Disabling VLAN_HWTAGGING Message-ID: <20040330103251.GA92824@ip.net.ua> In-Reply-To: <200403290936.49345.jbarrett@amduat.net> References: <200403251118.40718.jbarrett@amduat.net> <200403270848.37996.jbarrett@amduat.net> <20040329081224.GC70021@ip.net.ua> <200403290936.49345.jbarrett@amduat.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 29, 2004 at 09:36:49AM -0800, Jacob S. Barrett wrote: > On Monday 29 March 2004 12:12 am, Ruslan Ermilov <ru@FreeBSD.org> wrote: > > No, this is not of course expected. Can you add some debug printfs > > in the ng_vlan.c:ng_vlan_rcvdata() and see if it ever receives the > > VLAN tag, and if so, print its value (perhaps the tag is entered by > > a driver in a network byte order). >=20 > Bingo... I will dig around in if_nge.c to figure out where to swap the by= tes. >=20 > > Well, for IP/TCP/UDP checksumming, it's possible to switch the > > corresponding bit in the interface's enabled capabilities field. > > OTOH, switching VLAN stripping on/off requires reprogramming of > > the hardware. > > > > Generally, if the hardware supports IP/TCP/UDP checksumming and > > or VLAN tag removal/insertion, it's better to use it. We'd > > better find the root of the problem and fix it. ;) >=20 > I agree, so now that we have found it I will try to fix it. Thanks for y= our=20 > help. >=20 OK. After configuring our GigE switch to pass the VLAN packets unstripped, I've been able to reproduce this problem on 4.x too. So I've just committed a fix for this into HEAD, please test it: $FreeBSD: src/sys/dev/nge/if_nge.c,v 1.55 2004/03/30 10:24:52 ru Exp $ The DP8382[01] data sheets are not very specific about the issue, and most probably, the initial VLAN support has been tested between two nge(4) cards, so the problem didn't manifest itself until now. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAaUzTUkv4P6juNwoRAswcAJ9HkcSi1IYQkb3NW25Z66rWehSB4wCePBMP jPqkpaMR+0PJmmxYzPPKFhM= =qiXi -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040330103251.GA92824>