Date: Fri, 4 Jun 2004 11:50:02 +0200 From: Koos Vriezen <k.vriezen@vgelder.com> To: freebsd-cvsweb@FreeBSD.org Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) Message-ID: <20040604095002.GA28772@vgelder.com> In-Reply-To: <20040603093042.GB12805@vgelder.com> References: <20040602171019.GA12732@vgelder.com> <20040603093042.GB12805@vgelder.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Jun 03, 2004 at 11:30:42AM +0200, Koos Vriezen wrote: > > > > download works, annotated AFAICS doesn't (but I never used this one) and > > colored does not work either. > > For revision 1.2 for file 'myfile' in module 'mymodule' for our > > internal web server (www.intern): > > preferred: > > http://www.intern/cgi-bin/cvsweb/mymodule/myfile.diff?r1=1.1;r2=1.2 > > colored: > > http://www.intern/cgi-bin/cvsweb/mymodule/myfile.diff?r1=1.1;r2=1.2;f=h Ok, turned out to be the query string was not parsed right. The string r1=1.1;r2=1.2 was changed to r1%3D1.1%3Br2%3D1.2 at line 387: my %query = (); if (defined($ENV{QUERY_STRING})) { $ENV{QUERY_STRING} = uri_escape($ENV{QUERY_STRING}); for my $p (split(/[;&]+/, $ENV{QUERY_STRING})) { next unless $p; $p =~ y/+/ /; my ($key, $val) = split(/=/, $p, 2); next unless defined($key); $val = 1 unless defined($val); ($key = uri_unescape($key)) =~ /[[:graph:]]/ or next; ($val = uri_unescape($val)) =~ /[[:graph:]]/ or next; $query{$key} = $val; } } commenting out the 'uri_escape' line makes cvsweb work again. Up to you and/or debian maintainer to fix this, or is it my perl? (seem more likely to me to have a url_unescape or indeed nothing than escaping but I'm not in to this topic ATM) Thanks for the help, Koos ***************DISCLAIMER*************** Bewijs van Afstand: Dit emailbericht is slechts bestemd voor de personen aan wie het is gericht en kan informatie bevatten die persoonlijk of vertrouwelijk is en niet openbaar mag worden gemaakt zonder goedkeuring van de auteur. Indien u dit bericht per vergissing heeft ontvangen, verzoeken wij u ons op de hoogte te stellen en het bericht te vernietigen zonder het te kopiëren of te distribueren. Ons bedrijf staat niet in voor juiste en volledige overbrenging van de inhoud van een verzonden bericht, noch voor de tijdige ontvangst daarvan. Disclaimer: This E-mail is for use of the intended recipient(s) only and can contain information that is personal or confidential. It is prohibited to distribute the content of this message without the author's prior permission. If you have received it in error, please notify the sender and immediately delete this message without distributing or retaining copies hereof. Our company is not responsible for the comprehensiveness of this message nor it's time of delivery. *********************************************
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040604095002.GA28772>