Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Sep 2004 04:09:55 -0000
From:      Max Laier <max@love2party.net>
To:        pf4freebsd@freelists.org
Cc:        Pyun YongHyeon <yongari@kt-is.co.kr>
Subject:   [pf4freebsd] Re: Strange problem/Need help
Message-ID:  <200407260137.46024.max@love2party.net>
In-Reply-To: <20040723083119.GA3240@kt-is.co.kr>
References:  <200407230602.34822.max@love2party.net> <20040723083119.GA3240@kt-is.co.kr>

next in thread | previous in thread | raw e-mail | index | archive | help

--Boundary-03=_KREBBQ/Yfbd+MbQ
Content-Type: multipart/mixed;
  boundary="Boundary-01=_DREBBaCzq5Kw+AW"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_DREBBaCzq5Kw+AW
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 23 July 2004 10:31, Pyun YongHyeon wrote:
> On Fri, Jul 23, 2004 at 06:02:27AM +0200, Max Laier wrote:
>  > Hi,
>  >
>  > Christian S.J. Peron reported a very strange problem with pf in a rece=
nt
>  > current kernel. It turned out (after days of brainwracking debugging)
>  > that the problem went away by disabling the i386 optimized version of
>  > in4_cksum(). The problem I am having with this, is that I can't explain
>  > why this (standalone) thing would break all of a sudden (earlier kernel
>  > seemed to work). So what I am looking for are other examples for this
>  > behavior or possible explanations.
>
> Hi Max,
>
> I don't know where the problem is.... :-(
>
> How about this? Instead of using hand-optimized code, it would be
> better to use system supplied one. This will work on icc too.
> I have to go out now. Please review the patch and let me know your
> opinions.(It wasn't tested at all.) This one can be used for a while.
> Personally, I really want to import NetBSD's approach.

I like it. I can recall that we talked about using in_cksum_skip when we fr=
ist=20
did in4_cksum, but for some reason it wasn't useable then (iirc). Can your=
=20
remember the complete story?

Anyway, I ran this on my gateway for two days and it seems okay. I'd like t=
o=20
have a little more feedback before commiting, though. Please copy attached=
=20
in4_cksum.c into src/sys/contrib/pf/netinet, build and run with it. If you=
=20
have any shake out, please let me know.

Pyun, I assert the original OpenBSD in4_cksum.c copyright on this one. Are =
you=20
okay with this solution?

=2D-=20
/"\  Best regards,			| mlaier@freebsd.org
\ /  Max Laier				| ICQ #67774661
 X   http://pf4freebsd.love2party.net/	| mlaier@EFnet
/ \  ASCII Ribbon Campaign		| Against HTML Mail and News

--Boundary-01=_DREBBaCzq5Kw+AW--

--Boundary-03=_KREBBQ/Yfbd+MbQ
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQBBBERJXyyEoT62BG0RAoa5AJ9bjVNWvSrrtU5fiE56Nzs2WHk1OQCcCVcP
Jr8eMYrev/gyIO3JXRrOo1c=
=L7hU
-----END PGP SIGNATURE-----

--Boundary-03=_KREBBQ/Yfbd+MbQ--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407260137.46024.max>