Date: Fri, 2 Dec 2005 12:15:34 +0100 From: Jean-Yves Lefort <jylefort@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: emulation@freebsd.org Subject: Re: cvs commit: ports/audio/linux-openal bsd.linux.mk Message-ID: <20051202121534.44c2c7be.jylefort@FreeBSD.org> In-Reply-To: <20051201152026.lxwvpjokc0sw0okc@netchild.homeip.net> References: <200511261918.jAQJIp91001719@repoman.freebsd.org> <20051201152026.lxwvpjokc0sw0okc@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Fri__2_Dec_2005_12_15_34_+0100_LMQfKe5SCA/9DT0/ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, 01 Dec 2005 15:20:26 +0100 Alexander Leidinger <Alexander@Leidinger.net> wrote: > Jean-Yves Lefort <jylefort@FreeBSD.org> wrote: >=20 > [moving to emulation@] >=20 > I have a backlog of cvs-all mails... I'm slowly catching up and noticed t= his > one without further looking if someone wrote some comments (but I looked = at > rev 1.2 of the file). >=20 > > jylefort 2005-11-26 19:18:51 UTC > > > > FreeBSD ports repository > > > > Added files: > > audio/linux-openal bsd.linux.mk > > Log: > > Add my RPM support infrastructure. > ^^ > Isn't this a little bit selfish? ;-) >=20 > Ok, more serious comments (*constructive* critic): > - that's the wrong name for this file, bsd.rpm.mk or > bsd.linuxrpm.mk would be better, since it does not contain > all linux related mk-fu Agreed. > - install-time generated plists are evil (as per discussion on > ports@ a while ago (and as of very recent experience with the > linux ports), so the pre-install target should be removed and > a real plist should be generated), have a look at the linux-gtk > Makefile for a target which generates an initial plist (needs > to be modified a little bit afterwards) So we still don't agree on this. I guess we never will. :( > - it should be installed into PORTSDIR/Mk, so that other port can > use it I agree, but I don't think that I have the right to (nor that it is good to) add files to Mk/ without portmgr reviewal. I had planned to contact emulation@ and discuss the steps needed to move the file to Mk/ and have it pulled in from bsd.port.mk (via a USE_LINUX_RPM knob, or something). Glad to see that you read cvs-ports. :) > - does the ppc have a linuxolator? I'm not sure (I guess not). I'll remove the powerpc stuff if someone confirms that there's no linux emulation on powerpc. > - why do you use different ways of specifying the paths in DESCR > and MD5_FILE? > - why do you specify DESCR at all? The idea is to use the FreeBSD native port's pkg-descr. > - INSTALLS_LINUX_SHLIB should be removed, fix the FreeBSD one > instead to not do anything in the USE_LINUX case and reuse the > name of the FreeBSD one (-> more consistent and easy > description on the porters handbook) Agreed. > In general it's nice to see someone working on this. And I like the idea = to > use rpm2cpio instead of rpm. We could get rid of the rpm-db in the linux > base ports this way (this removes some of those annoying warnings on > pkg_deinstall). And it allows to modify the contents before installing, which is not possible when installing with rpm. I don't know what to do next. I can file a PR for inclusion in Mk/, but it'd feature my own plist generator. Directions are welcome. --=20 Jean-Yves Lefort jylefort@FreeBSD.org http://lefort.be.eu.org/ --Signature=_Fri__2_Dec_2005_12_15_34_+0100_LMQfKe5SCA/9DT0/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDkCzWyzD7UaO4AGoRAua/AJ9whezEAPTgitSFUzNV7kWhzdB05wCfSLbO NDb8ZEMMVdMdt33EeVeO0jk= =wWwz -----END PGP SIGNATURE----- --Signature=_Fri__2_Dec_2005_12_15_34_+0100_LMQfKe5SCA/9DT0/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051202121534.44c2c7be.jylefort>