Date: Fri, 5 Oct 2007 21:38:25 +0200 From: "Ralf S. Engelschall" <rse+freebsd-current@FreeBSD.org> To: freebsd-current@freebsd.org Subject: cosmetics: bsdlabel fstype for ZFS partitions? Message-ID: <20071005193825.GA66299@engelschall.com>
next in thread | raw e-mail | index | archive | help
I've today switched the boot disk of a FreeBSD 7 system from UFS-only to UFS (/boot) plus ZFS (for /, /usr, etc). For this I the first time created a ZFS pool from a _partition_ instead of the usual whole slices or disks. In the bsdlabel(8) editing session (where I merged some of the previous UFS partitions to a single large one for ZFS) I recognized that we do not have a keyword for ZFS on the "fstype" column: | # size offset fstype [fsize bsize bps/cpg] | a: 1048576 0 4.2BSD 2048 16384 8 | b: 4142736 1048576 swap | c: 33554052 0 unused 0 0 # "raw" part, don't edit | d: 28362740 5191312 unused 0 0 ^^^^^^ I currently use "unused" here for the partition of the ZFS pool and everything works just fine, of coure. But it looks a little bit strange to me and this small cosmetic issue should be fixed IMHO. So, shouldn't we define a "zfs" filesystem type in sys/sys/disklabel.h:fstypenames plus a corresponding "#define FS_ZFS ?? /* Sun ZFS */"? If yes, what value would FS_ZFS be defined to? BTW, same for the disk type, I think. Here a numeric value certainly was already choosen, as Sun's GRUB is booting from ZFS disks, right? -- rse@FreeBSD.org Ralf S. Engelschall FreeBSD.org/~rse rse@engelschall.com FreeBSD committer www.engelschall.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071005193825.GA66299>