Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Mar 2008 23:49:47 +0200
From:      Roman Divacky <rdivacky@freebsd.org>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        current@freebsd.org
Subject:   Re: shared lock instead of exclusive in set_rootvnode
Message-ID:  <20080330214947.GA16374@freebsd.org>
In-Reply-To: <20080304111542.GA57756@deviant.kiev.zoral.com.ua>
References:  <20080303200946.GA79061@freebsd.org> <20080304111542.GA57756@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 04, 2008 at 01:15:42PM +0200, Kostik Belousov wrote:
> On Mon, Mar 03, 2008 at 09:09:46PM +0100, Roman Divacky wrote:
> > hi
> > 
> > in set_rootvnode() there is 
> > 
> > p->p_fd->fd_cdir = rootvnode;
> > p->p_fd->fd_rdir = rootvnode;
> > 
> > protected just by FILEDESC_SLOCK(), I dont think this is correct
> > although it might be benign as this is used only during boot.
> > 
> > still, if it's not correct it should be fixed
> > 
> > comments?
> 
> Seems right. Did you boot with patched kernel ?

I've been running with this patch for a month... is it time to commit
this?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080330214947.GA16374>