Date: Wed, 17 Sep 2008 05:27:27 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: ports@freebsd.org, John Baldwin <jhb@freebsd.org>, Alex Dupre <ale@FreeBSD.org> Subject: Re: OPTIONS handling doesn't seem to work fully in dependencies anymore Message-ID: <20080917052727.GA71514@FreeBSD.org> In-Reply-To: <48D03248.1040109@FreeBSD.org> References: <200809151036.19674.jhb@freebsd.org> <48CEBE6E.1030508@FreeBSD.org> <48CFCE01.4050304@FreeBSD.org> <48D03248.1040109@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 16, 2008 at 03:25:12PM -0700, Doug Barton wrote: > Alex Dupre wrote: > > Doug Barton ha scritto: > >> Bug, and at first glance I think your analysis is correct about the > >> cause. > > > > Surely a bug, but the mentioned code is what was added in rev 1.560 > > (http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk?r1=1.560#rev1.560) > > exactly to add this feature, and AFAIR it worked. > > The commit log refers to a different problem than John reported. The > commit log refers to the problem of a saved options file that doesn't > have all of the new OPTIONS for a new version of the port. > > John was referring to the problem of 'make config' not being called for > ports being installed as dependencies of a port that has OPTIONS. Nevertheless, going back to rev. 1.559 of b.p.m. restores correct behavior. Quite ironically, since commit logs tells us that "The end user impact of this is more blue screens." for rev. 1.560, which I tend to blame now. I also don't think that we can simply tell our users to user portmaster or some force-config switches. This bug is quite annoying, and should be fixed to work in vanilla environment environment with default settings. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080917052727.GA71514>