Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Jun 2010 13:38:03 +0300
From:      Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
To:        Rick Macklem <rmacklem@uoguelph.ca>
Cc:        freebsd-fs@freebsd.org
Subject:   Re: Testers: NFSv3 support for pxeboot for nfs diskless root
Message-ID:  <20100611103803.GA1855@pm513-1.comsys.ntu-kpi.kiev.ua>
In-Reply-To: <Pine.GSO.4.63.1006091934390.22971@muncher.cs.uoguelph.ca>
References:  <Pine.GSO.4.63.1006091934390.22971@muncher.cs.uoguelph.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 09, 2010 at 07:38:24PM -0400, Rick Macklem wrote:
> I put 3 patches (you need to apply them all) here:
> http://people.freebsd.org/~rmacklem/nfsdiskless-patches/
> 
> They convert lib/libstand/nfs.c and pxeboot to use NFSv3 instead
> of NFSv2 (unless built with OLD_NFSV2 defined). Initial test
> reports have been good. (one has it working ok and the other has
> a problem in an area not related to the patches, it appears)
> 
> So, if others are interested in testing these, it would be
> appreciated, rick

Shouldn't return values from malloc() calls be checked?
Also additional checks for NULL values before free() calls can be removed,
at least this will reduce size of code.  There is PR/83424 related to this.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100611103803.GA1855>