Date: Fri, 29 Oct 2010 18:17:27 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-stable@freebsd.org, Alexander Zagrebin <alexz@visp.ru> Subject: Re: 8.1-STABLE: zfs and sendfile: problem still exists Message-ID: <20101029151727.GY2392@deviant.kiev.zoral.com.ua> In-Reply-To: <4CCAE2B6.1050906@icyb.net.ua> References: <4CCACDC0.7050802@icyb.net.ua> <1BDB4D1B02274CC8AA2DD5E68190CB5D@vosz.local> <20101029145349.GX2392@deviant.kiev.zoral.com.ua> <4CCAE2B6.1050906@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--A4wWcVSW3p6tJXaL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 29, 2010 at 06:05:26PM +0300, Andriy Gapon wrote: > on 29/10/2010 17:53 Kostik Belousov said the following: > > Could it be the priming of the vm object pages content ? >=20 > Sorry, not familiar with this term. > Do you mean prepopulation of vm object with valid pages? >=20 > > Due to double-buffering, and (possibly false) optimization to only >=20 > What optimization? On zfs vnode read, the page from the corresponding vm object is only populated with the vnode data if the page already exists in the object. Not doing the optimization would be to allocate the page uncoditionally on the read if not already present, and copy the data from ARC to the page. >=20 > > perform double-buffering when vm object already has some data cached, > > reads can prime vm object page list before file is mmapped or > > sendfile-ed. > >=20 >=20 > No double-buffering is done to optimize anything. Double-buffering > is a consequence of having page cache and ARC. The special > "double-buffering code" is to just handle that fact - e.g. making > sure that VOP_READ reads data from page cache instead of ARC if it's > possible that the data in them differs (i.e. page cache has more > recent data). > > So, if I understood the term 'priming' correctly, no priming should > ever occur. The priming is done on the first call to VOP_READ() with the right offset after the page is allocated. --A4wWcVSW3p6tJXaL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAkzK5YcACgkQC3+MBN1Mb4jUgACfTe+Vbokx+wrN/YfHpX2YrOmV 2HIAn0VtobxirJ/xcvAsPYt8oxDw98pf =Lpdl -----END PGP SIGNATURE----- --A4wWcVSW3p6tJXaL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101029151727.GY2392>