Date: Sun, 18 Sep 2011 20:56:47 +0200 From: Juergen Lock <nox@jelal.kn-bremen.de> To: bf1783@gmail.com Cc: freebsd-multimedia@freebsd.org, gerald@freebsd.org, Juergen Lock <nox@jelal.kn-bremen.de> Subject: Re: Has anyone tested the jack update - am I ok to commit it? Message-ID: <20110918185647.GA28605@triton8.kn-bremen.de> In-Reply-To: <CAGFTUwObv-92bVdF%2B7YZ7Xdf-gTp-_0N-MOQfq=S_y=40PDApQ@mail.gmail.com> References: <CAGFTUwNMqpOcYLZCzbZ7tj5qqZF6UXm6zv-%2BH3ZxYNa9U9VQCA@mail.gmail.com> <20110918152101.GA88715@triton8.kn-bremen.de> <CAGFTUwObv-92bVdF%2B7YZ7Xdf-gTp-_0N-MOQfq=S_y=40PDApQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 18, 2011 at 12:07:50PM -0400, b. f. wrote: > On 9/18/11, Juergen Lock <nox@jelal.kn-bremen.de> wrote: > > On Sat, Sep 17, 2011 at 10:19:27PM -0400, b. f. wrote: > > >> -- clean up ugly flag handling > >> > > Can you elaborate? > > As in the patch I sent to you, along with the doxygen-related changes. Hm that never arrived here. :( (Or did you send it to a list only? Then I missed it.) > CFLAGS and CPPFLAGS are already being passed in do-configure, so it > is only necessary to append to them, but not to explicitly add them to > CONFIGURE_ENV. This also makes it easier to check their values via > "make -V". Also, it was always advisable to perform linking via the > compiler with the flags issued for compilation, and now it is > essential for flags like -flto and -fstack-protector, which some > people are using with ports, so our previous careless handling of > LDFLAGS is being cleaned up (cf. > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=ports/157936, etc.) , and > it is important to try (within reason) to honor the user-requested > LDFLAGS just as we do for CFLAGS. Therefore, just append the addition > to the library search path to LDFLAGS, and pass the result, rather > than clobbering the flags. Anyway, you are right, that should be cleaned up. I have now made a new update including your suggestions and tested it with ardour3 again: http://people.freebsd.org/~nox/tmp/jack-0.121.2.patch The jack_get_microseconds() code I added to files/patch-drivers-oss-oss_driver.c may not be the best solution, I added it to fix a segfault at jackd start because driver->engine was NULL in oss_driver_start()... Thanx for testing, :) Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110918185647.GA28605>