Date: Thu, 4 Jul 2013 20:25:28 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Andre Albsmeier <Andre.Albsmeier@siemens.com> Cc: "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: FreeBSD-9.1: machine reboots during snapshot creation, LORs found Message-ID: <20130704172528.GL91021@kib.kiev.ua> In-Reply-To: <20130704142919.GA1798@bali> References: <20130531122611.GA6607@bali> <201305311051.03157.jhb@freebsd.org> <20130616063942.GA72803@bali> <201306171530.31208.jhb@freebsd.org> <20130704051409.GA22021@bali> <20130704052440.GG91021@kib.kiev.ua> <20130704052659.GA23398@bali> <20130704061550.GI91021@kib.kiev.ua> <20130704142919.GA1798@bali>
next in thread | previous in thread | raw e-mail | index | archive | help
--+odIVbikbWChO5Pj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2013 at 04:29:19PM +0200, Andre Albsmeier wrote: > OK, patch is applied. I will reboot the machine later > and see what happens tomorrow in the morning. However, > it might take a few days since the last 2 weeks all was > fine. >=20 > BTW, should this patch be used in general or is it just > for debugging? My understanding is that it is something > which could stay in the code... Patch is to improve debugging. I probably commit it after the issue is closed. Arguments against the commit is that the change imposes small performance penalty due to save and restore of the %ebp (I doubt that this is measureable by any means). Also, arguably, such change should be done for all functions in support.s, but bcopy() is the hot spot. --+odIVbikbWChO5Pj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJR1bAHAAoJEJDCuSvBvK1BIGoQAIMnJE9nUDY0qixM7EHG/A8Q q+hiwDtOqUyBfEsmrC/+hQMGZJYmyTpI+pgsnI1VWwZgeUaqswv9a+h2qvHqTDCu 8IGJZRtDpTS+tGnDAAxxiEVJ+NGJ3gSDYx2qtSty7eQVQls7eB4q87FA6I+6cZex djinQtLJGo2oesUzojvrVdkFS8GgvO5wm4aveoWAXGCx1otPR+bswjLSBFpToDm4 KE5lFtRYVsBSggaw8TzDJrUIpDqhXYY3dObgAtpz0sCINwGaKvSGTIQxJFpN1cW+ JnMmzPF0SePm7IJd0jRzmkC2X/5aNaziw0P6cgWCnY5Qjs16jr3HRroU0tzJVM3L Vq3m84xrQCZlkhg2hsE5YMMuVv+mEeyL77ev69oFVuplIj/oifsQvv6wXkaVKc06 3Wte4XcR1w3l9qRgI2Nj5sp1KTX2dVJ0b+Cw914HygeQlZ5eAiU/XucVmPe6pnCq ReLUyFJVjVFjbG4x2PhHGNGdJ17hVsfLumREanaZUxhUDQ+KQ1BPeU7OKtBcezlS Nm2gNtaHBCSY0yQgAjbbd33j5WhEYeqAFM28Vzz/DCj09pWM9RisNpzfsFabjW0v OnBpKyAzmPyo2SL8Y9X32B34p42GNXy4/UVQq9JziiyNIvReza+EtnXDSjOnWEtk Eka18BFj4vrFmd75N9Uf =2GFI -----END PGP SIGNATURE----- --+odIVbikbWChO5Pj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130704172528.GL91021>