Date: Fri, 13 Dec 2013 13:26:28 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-net@freebsd.org Cc: Yong-Hyeon Pyun <pyunyh@gmail.com>, Michael Tuexen <Michael.Tuexen@lurchi.franken.de>, Adrian Chadd <adrian@freebsd.org>, Jack F Vogel <jfv@freebsd.org>, John-Mark Gurney <jmg@funkthat.com> Subject: Re: A small fix for if_em.c, if_igb.c, if_ixgbe.c Message-ID: <201312131326.28952.jhb@freebsd.org> In-Reply-To: <CAJ-VmomNf2m3Qinxz_vN5gXPcMnJmysamR4LPRcK=vPKJvG_DA@mail.gmail.com> References: <521B9C2A-EECC-4412-9F68-2235320EF324@lurchi.franken.de> <CAJ-Vmok9oy5BTU8f2KrRU5NBaxOZWF11qO2Z7=KTrkFhfBc0cQ@mail.gmail.com> <CAJ-VmomNf2m3Qinxz_vN5gXPcMnJmysamR4LPRcK=vPKJvG_DA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, December 09, 2013 2:37:08 pm Adrian Chadd wrote: > Jack / John - thoughts? Note that if_start has always worked the way if_transmit would work with the err = 0 change. All the other drivers in the tree are already giving you an error if an earlier packet in the IFQ fails to transmit, and it's been that way for decades. If you decide to make if_transmit precise (only return an error if the specific packet fails), the corresponding change for if_start() drivers would be to never return an error ever. It's not clear to me what the impact of that would be. However, the current patch to return 0 in the drbr_putback case would at least restore things to the previous status quo from the past few decades for both if_start() and if_transmit() drivers. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312131326.28952.jhb>