Date: Sun, 16 Mar 2014 22:07:05 +0100 From: Thierry Thomas <thierry@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: emulation@FreeBSD.org Subject: Re: Mk/bsd.linux-rpm.mk does not allow grouping rules (:something) Message-ID: <20140316210705.GJ15009@graf.pompo.net> In-Reply-To: <20140316185515.00006495@unknown> References: <20140212201524.8192371E4AF@graf.pompo.net> <20140316185515.00006495@unknown>
next in thread | previous in thread | raw e-mail | index | archive | help
Le dim 16 mar 14 à 18:55:15 +0100, Alexander Leidinger <Alexander@Leidinger.net>
écrivait :
> On Wed, 12 Feb 2014 21:15:24 +0100 (CET)
> Thierry Thomas <thierry@FreeBSD.org> wrote:
>
> > >Synopsis: Mk/bsd.linux-rpm.mk does not allow grouping rules
> > >(:something)
> [...]
> > >Fix:
> > Please apply this patch:
> >
> > --- bsd.linux-rpm.mk.diff begins here ---
> > --- Mk/bsd.linux-rpm.mk.orig 2014-01-21 21:18:37.000000000
> > +0100 +++ Mk/bsd.linux-rpm.mk 2014-02-12 21:03:50.000000000
> > +0100 @@ -95,7 +95,7 @@
> > # is not true.
> >
> > DISTFILES?= ${DISTNAME}${EXTRACT_SUFX}
> > -BIN_DISTFILES:= ${DISTFILES}
> > +BIN_DISTFILES:= ${_DISTFILES}
> > SRC_DISTFILES?= ${DISTNAME}${SRC_SUFX}
> > EXTRACT_ONLY?= ${BIN_DISTFILES}
>
> This is all what is needed to make this work? Did you test this with
> some linux ports (e.g. linux_base)?
Seems so!
> If you have tested and there is no fallout, I have no objections.
> If you haven't tested a lot I recommend to test (if in doubt, an
> exp-run, else a representative list of ports and a commitment to fix
> reports of broken ports).
I have tested the proposed patch with the port devel/linux-f10-devtools
(the used patch is included in the PR, paragraph "How-To-Repeat"), but I
have not tested it against other ports.
In this case, an exp-run is not very useful: if you only apply the patch
to Mk/bsd.linux-rpm.mk, anything is modified. To see the change, the
other linux ports have to use the groups.
I'll do the test for emulators/linux_base-f10 and some others, and will
post the results here.
Best regards,
--
Th. Thomas.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140316210705.GJ15009>