Date: Tue, 16 Jun 2015 01:18:32 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: Re: [rfc] fix umul_ppmm() in our libgcc Message-ID: <20150616011832.146e0f0e@kan> In-Reply-To: <CAJ-Vmonsmu5dGtWKhJchzZfSsVUjtwEVSEij4u6kwk64E0ZOXw@mail.gmail.com> References: <CAJ-Vmonsmu5dGtWKhJchzZfSsVUjtwEVSEij4u6kwk64E0ZOXw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/3d+MeqRa5bvdTBGI0e9/E5h Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 13 Jun 2015 15:41:34 -0700 Adrian Chadd <adrian@freebsd.org> wrote: > Hi, >=20 > our libgcc in -base is very .. old. It chokes when compiling for > mips32. This patch seems to do the right thing. >=20 > Does anyone have any positive/negative feedback? >=20 > Thanks, >=20 >=20 > -adrian Newer version of GCC use similar construct, but actual multiplication is done using more correct selection of casts: UDItype __x =3D (UDItype) (USItype) (u) * (USItype) (v); I suggest you follow their lead. No objections otherwise. --=20 Alexander Kabaev --Sig_/3d+MeqRa5bvdTBGI0e9/E5h Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJVf7GoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+ky0P/2GMR7QLcs53VX/Hz3cNBZ/n 02VBYoUvWs7VJ/fVn4+jGeZyO1LR+Qwu9WcDaeEONo/4PsfuCNjZ7etMIaXG9dt8 KhQugRx9soh3040EniwVXc1lBASCVhkWA3k2PKWyyPfDwEqZ14f3/DdB6iPCMHpu mxA1y+MRF9j4pAmusYya4SyT9ThhHQhC+2reaoBvUpPG8neA6K6kyGi5+ZL7Ejqh WGKXfEjV+AGIvoI4DpUVXvahy/hTY1D6nQlHbwypxepv7FLh5czwh7Pk3kwmITsb hvsVpkWl0pS8iUsHUpIXQR1F/zBfcAb/MqcsYOlLW6pYwj8KfHUWiylfj4h5IM7i DS+c9fbltrOsC634Kb0cCEB7/fLN4VR1qM8g9gkSRMBbyDH2gHYy7h3//hetXrRN D3PgyL945rnfssz3IUTwwUxEyyn8cyostpuDsfTNboRL/FiQDT7h3Qd+FvLN/F4b +d9nbze3reEauAxQQQKEdi+/C7GPkjWbMlf/U5ezpwUhnbbjsy6wsnGAg/N4W7qB mRC3tpCdEkYHuF55LgAFlmCdht+zrYBsmMt4ZENQE+SwJCW+gyJUgva0GJltG3Iv jPccIr4h1Iy2FLNYOYYfxo/0o6gSG5vQSHaa7mZ5Ueyprnal6FrATBhdn+B9Gcun qt5bkdJHec+O4fP6hWTQ =bzBe -----END PGP SIGNATURE----- --Sig_/3d+MeqRa5bvdTBGI0e9/E5h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150616011832.146e0f0e>