Date: Fri, 27 Nov 2015 14:42:06 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: Rainer Hurling <rhurlin@gwdg.de>, Gerald Pfeifer <gerald@pfeifer.com>, freebsd-ports@freebsd.org Subject: Re: lang/gcc48 fails to build [on HEAD] Message-ID: <20151127134205.GB17547@ivaldir.etoilebsd.net> In-Reply-To: <20151127142405.20af4925@kalimero.tijl.coosemans.org> References: <564040EE.6090504@gwdg.de> <alpine.LSU.2.20.1511091105470.2548@anthias> <5642362C.7000609@gwdg.de> <20151127125954.GA17547@ivaldir.etoilebsd.net> <20151127142405.20af4925@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZoaI/ZTpAVc4A5k6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Nov 27, 2015 at 02:24:05PM +0100, Tijl Coosemans wrote:
> On Fri, 27 Nov 2015 13:59:54 +0100 Baptiste Daroussin <bapt@FreeBSD.org> =
wrote:
> > On Tue, Nov 10, 2015 at 07:23:40PM +0100, Rainer Hurling wrote:
> >> I think I found the problem.
> >>=20
> >> In my initial mail of this thread, I reported, that after upgrading
> >> Freebsd 11.0-CURRENT to r290538 (including locale and localedef update=
s)
> >> I am not able to build lang/gccXX any more. All I get are errors like
> >> that in usr/ports/lang/gccXX/work/build/gcc:
> >>=20
> >> ----
> >> In file included from .././../gcc-4.8.5/gcc/genflags.c:26:
> >> In file included from ./tm.h:16:
> >> ./options.h:4293:3: error: redefinition of enumerator 'OPT_C'
> >> OPT_C =3D 129, /* -C */
> >> ^
> >> ----
> >>=20
> >> After more than 20 of them the build stops with
> >> fatal error: too many errors emitted, stopping now [-ferror-limit=3D]
> >> 20 errors generated.
> >>=20
> >>=20
> >> This is with locale for Germany:
> >> LANG=3Dde_DE.UTF-8
> >> LC_CTYPE=3D"de_DE.UTF-8"
> >> LC_COLLATE=3D"de_DE.UTF-8"
> >> LC_TIME=3D"de_DE.UTF-8"
> >> LC_NUMERIC=3D"de_DE.UTF-8"
> >> LC_MONETARY=3D"de_DE.UTF-8"
> >> LC_MESSAGES=3D"de_DE.UTF-8"
> >> LC_ALL=3D
> >>=20
> >>=20
> >> If I use 'LC_COLLATE=3D"C"' for the build, the build works fine again:
> >>=20
> >> cd /usr/ports/lang/gcc48
> >> env LC_COLLATE=3D"C" make
> >> ...
> >>=20
> >>=20
> >> So it seems, that something with the new 'locale' code in base of HEAD
> >> is not working as expected here? (At least for other locales than US?)
> >>=20
> >> I added bapt@, because he is the author introducing the new code into =
HEAD.
> >>=20
> >> Hope, my explanations are clear enough to get the problem. Please feel
> >> free to ask for more information, if needed.
> >=20
> > Your explanations are good, sorry for the delay for my reply I will look
> > into it.
>=20
> I ran into this with lang/sdcc* which includes cpp from gcc. At some
> point the build runs an awk script (opt-gather.awk) that collects command
> line options defined in *.opt files, sorts them and then puts them into
> a C array. The problem seems to be that FreeBSD awk takes collation into
> account when sorting strings while GNU awk doesn't. POSIX says that
> FreeBSD is correct, so I was thinking of adding something like this to
> bsd.port.mk:
>=20
> USE_LOCALE?=3D C
> LANG=3D ${USE_LOCALE}
> LC_ALL=3D ${USE_LOCALE}
> .export LANG LC_ALL
>=20
> This gives a consistent locale environment for port builds. Some ports
> already set LANG or LC_ALL. That would have to be reviewed and I haven't
> had time for that yet.
yeah we should imho to that. The same issue appears with GNU tr which also
do not take in account collation (IIRC) while ours do.
Best regards,
Bapt
--ZoaI/ZTpAVc4A5k6
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlZYXa0ACgkQ8kTtMUmk6ExonACfXl/ZaXS+ACv/PL1sanawZ27y
eK8An2mMFSTVO2k8hPxLLjXJ5GOBrDAJ
=X2dD
-----END PGP SIGNATURE-----
--ZoaI/ZTpAVc4A5k6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151127134205.GB17547>