Date: Sat, 1 Oct 2016 22:16:55 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Alexander Kabaev <kabaev@gmail.com>, Lewis Donzis <lew@perftech.com>, deischen@freebsd.org, freebsd-arch@freebsd.org Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11 Message-ID: <20161001201655.GA91457@stack.nl> In-Reply-To: <20161001092515.GW38409@kib.kiev.ua> References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> <20160930152006.GS38409@kib.kiev.ua> <20160930184418.1047afc2@kan> <20161001092515.GW38409@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 01, 2016 at 12:25:15PM +0300, Konstantin Belousov wrote: > On Fri, Sep 30, 2016 at 06:44:18PM -0400, Alexander Kabaev wrote: > > No objection, but possible suggestion: if the primary use of this > > symbol is for tests and nothing else, maybe it does belong in > > FBSDprivate_1.0 FBSDprivate_1.0 section instead? > Good question. The symbols are useful for real-world code, not only for > the tests. But I think that we should mark symbol as non-portable. Usual > approach of adding _np suffix seems to be the right thing to do there. > What about the following ? The idea is good, but perhaps call the function mq_getfd_np() to clarify it returns a file descriptor. Also, the __ versions should not be exported since they are not used outside the library (they can be exported if and when needed). -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161001201655.GA91457>