Date: Thu, 25 Jul 2019 13:40:17 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: Larry Rosenman <ler@freebsd.org>, Freebsd current <freebsd-current@freebsd.org> Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build Message-ID: <20190725134017.7c09692d@titan.knownspace> In-Reply-To: <CAOtMX2gORuRG_vwfHJa%2BAO9QM=A-wK1Ty%2BViZKG6e2QstQfyGw@mail.gmail.com> References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> <ac682e59ecc576fa5bd41a7015505624@FreeBSD.org> <CAOtMX2hqcjn1FOgCNXmnRdvNkpbqnoGDdn9zpHVo4iir_19-GQ@mail.gmail.com> <cf768fc3bd626abc24f07fbd55d23938@FreeBSD.org> <CAOtMX2gORuRG_vwfHJa%2BAO9QM=A-wK1Ty%2BViZKG6e2QstQfyGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Jul 2019 12:35:32 -0600 Alan Somers <asomers@freebsd.org> wrote: > On Thu, Jul 25, 2019 at 12:13 PM Larry Rosenman <ler@freebsd.org> > wrote: > > > > On 07/25/2019 1:10 pm, Alan Somers wrote: > > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman <ler@freebsd.org> > > > wrote: > > >> > > >> Um.... Who broke this? ... > > > "svn blame" suggests r350199 by kib. However, refcount.h should > > > only be included if lsof defines _KERNEL, which normal programs > > > shouldn't. So I think this should be considered a bug in lsof. > > > -Alan > > > > > > we *HAVE* to define _KERNEL, to get at the kernel structures..... > > Then I think you have to live with this amount of instability. > refcount(9) says that you should include <sys/param.h>. Did you do > that? If so, then this is a man page bug and refcount(9) should also > specify stdbool.h. > -Alan <sys/param.h> includes <sys/types.h> already, which typedefs bool. So <sys/param.h> should suffice to include in lsof. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190725134017.7c09692d>