Date: Wed, 4 Jun 2008 13:45:06 -0700 From: "Jack Vogel" <jfvogel@gmail.com> To: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Addition to the vlan driver Message-ID: <2a41acea0806041345x435ab61cq77f59a0cc0ae043f@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
I had our test group report a bug when using jumbo frames and vlans in the new igb driver. After a couple days chasing it down it turns out the issue is that the igb driver does not know when a vlan is first attached, and when you use jumbo frames you need to program a register with the maximum frame size. The test case sets the MTU first, then did the vlan setup, so the driver did not have the tag accounted for in the frame size, and thus the hardware was happily throwing frames away due to size :( Now, as a workaround I have them set up the vlan first and THEN change the MTU, but I'd rather not require that, so.... What I would like to do is add some code into the vlan_ioctl() routine that will make a call to the PARENT ioctl with SETVLAN type and an argument of the tag. By doing this both the em and igb drivers will be able to enable hardware vlan filtering as well, a feature we've never been able to use. Anyone see any issue with doing this or have any objections to it? Cheers, Jack
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a41acea0806041345x435ab61cq77f59a0cc0ae043f>