Date: Sun, 28 Apr 2002 18:33:16 +0200 From: =?ISO-8859-1?Q?Joachim_Str=F6mbergson?= <watchman@ludd.luth.se> To: FreeBSD-Audit <audit@FreeBSD.ORG> Subject: Please check my patches for bin/35307 Message-ID: <3CCC244C.4010601@ludd.luth.se>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------050407000506050405020706 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Aloha! As a sunday afternoon activity I've tried to close a PR. The PR I decided on fixing is bin/35307: http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/35307 Included with this mail are my patches to the header files listed in the PR. Could anybody please check to see if they are correct. Esp sys/times.h might be fishy. Also, how do I proceed from here? Add the patches to the PR and wait? There are tons of patches in the PR system waiting to be committed. Some more than two years out! -- Med vänlig hälsning, Cheers! Joachim Strömbergson ============================================================================ Joachim Strömbergson - ASIC designer, nice to *cute* animals. snail: phone: mail & web: Sävenäsgatan 5A +46 31 - 27 98 47 watchman@ludd.luth.se 416 72 Göteborg +46 733 75 97 02 www.ludd.luth.se/~watchman ============================================================================ --------------050407000506050405020706 Content-Type: text/plain; name="err.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="err.diff" --- /usr/include/err.h Mon Jan 28 14:11:19 2002 +++ err.h Sun Apr 28 17:21:49 2002 @@ -44,8 +44,8 @@ * for utilities to have to include one of them to include err.h, so we get * _BSD_VA_LIST_ from <machine/ansi.h> and use it. */ -#include <machine/ansi.h> #include <sys/cdefs.h> +#include <machine/ansi.h> __BEGIN_DECLS void err __P((int, const char *, ...)) __dead2 __printf0like(2, 3); --------------050407000506050405020706 Content-Type: text/plain; name="inttypes.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="inttypes.diff" --- /usr/include/inttypes.h Mon Jan 28 14:11:17 2002 +++ inttypes.h Sun Apr 28 17:26:11 2002 @@ -6,6 +6,7 @@ #ifndef _SYS_INTTYPES_H_ #define _SYS_INTTYPES_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> typedef __int8_t int8_t; --------------050407000506050405020706 Content-Type: text/plain; name="netdb.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="netdb.diff" --- /usr/include/netdb.h Mon Jan 28 14:11:19 2002 +++ netdb.h Sun Apr 28 17:31:00 2002 @@ -61,8 +61,8 @@ #ifndef _NETDB_H_ #define _NETDB_H_ -#include <machine/ansi.h> #include <sys/cdefs.h> +#include <machine/ansi.h> #ifdef _BSD_SIZE_T_ typedef _BSD_SIZE_T_ size_t; --------------050407000506050405020706 Content-Type: text/plain; name="stddef.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="stddef.diff" --- /usr/include/stddef.h Mon Jan 28 14:11:19 2002 +++ stddef.h Sun Apr 28 17:33:29 2002 @@ -38,6 +38,7 @@ #ifndef _STDDEF_H_ #define _STDDEF_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> typedef _BSD_PTRDIFF_T_ ptrdiff_t; --------------050407000506050405020706 Content-Type: text/plain; name="string.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="string.diff" --- /usr/include/string.h Mon Jan 28 14:11:19 2002 +++ string.h Sun Apr 28 17:35:55 2002 @@ -36,6 +36,7 @@ #ifndef _STRING_H_ #define _STRING_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> #ifdef _BSD_SIZE_T_ @@ -47,7 +48,6 @@ #define NULL 0 #endif -#include <sys/cdefs.h> __BEGIN_DECLS void *memchr __P((const void *, int, size_t)); --------------050407000506050405020706 Content-Type: text/plain; name="syslog.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="syslog.diff" --- /usr/include/syslog.h Mon Jan 28 14:11:17 2002 +++ syslog.h Sun Apr 28 17:38:56 2002 @@ -188,8 +188,8 @@ * for utilities to have to include one of them to include syslog.h, so we get * _BSD_VA_LIST_ from <machine/ansi.h> and use it. */ -#include <machine/ansi.h> #include <sys/cdefs.h> +#include <machine/ansi.h> __BEGIN_DECLS void closelog __P((void)); --------------050407000506050405020706 Content-Type: text/plain; name="time.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="time.diff" --- /usr/include/time.h Mon Jan 28 14:11:19 2002 +++ time.h Sun Apr 28 17:40:59 2002 @@ -41,6 +41,7 @@ #ifndef _TIME_H_ #define _TIME_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> #include <sys/_posix.h> --------------050407000506050405020706 Content-Type: text/plain; name="vis.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="vis.diff" --- /usr/include/vis.h Mon Jan 28 14:11:19 2002 +++ vis.h Sun Apr 28 17:43:30 2002 @@ -37,6 +37,7 @@ #ifndef _VIS_H_ #define _VIS_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> #ifdef _BSD_SIZE_T_ @@ -79,8 +80,6 @@ * unvis flags */ #define UNVIS_END 1 /* no more characters */ - -#include <sys/cdefs.h> __BEGIN_DECLS char *vis __P((char *, int, int, int)); --------------050407000506050405020706 Content-Type: text/plain; name="dirent.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dirent.diff" --- /usr/include/sys/dirent.h Mon Jan 28 14:11:17 2002 +++ dirent.h Sun Apr 28 17:45:12 2002 @@ -37,6 +37,7 @@ #ifndef _SYS_DIRENT_H_ #define _SYS_DIRENT_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> /* --------------050407000506050405020706 Content-Type: text/plain; name="inttypes.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="inttypes.diff" --- /usr/include/sys/inttypes.h Mon Jan 28 14:11:17 2002 +++ inttypes.h Sun Apr 28 18:05:22 2002 @@ -6,6 +6,7 @@ #ifndef _SYS_INTTYPES_H_ #define _SYS_INTTYPES_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> typedef __int8_t int8_t; --------------050407000506050405020706 Content-Type: text/plain; name="queue.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="queue.diff" --- /usr/include/sys/queue.h Sun Apr 28 12:57:24 2002 +++ queue.h Sun Apr 28 18:08:09 2002 @@ -37,6 +37,7 @@ #ifndef _SYS_QUEUE_H_ #define _SYS_QUEUE_H_ +#include <sys/cdefs.h> #include <machine/ansi.h> /* for __offsetof */ /* --------------050407000506050405020706 Content-Type: text/plain; name="syslog.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="syslog.diff" --- /usr/include/sys/syslog.h Mon Jan 28 14:11:17 2002 +++ syslog.h Sun Apr 28 18:11:26 2002 @@ -188,8 +188,8 @@ * for utilities to have to include one of them to include syslog.h, so we get * _BSD_VA_LIST_ from <machine/ansi.h> and use it. */ -#include <machine/ansi.h> #include <sys/cdefs.h> +#include <machine/ansi.h> __BEGIN_DECLS void closelog __P((void)); --------------050407000506050405020706 Content-Type: text/plain; name="times.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="times.diff" --- /usr/include/sys/times.h Mon Jan 28 14:11:17 2002 +++ times.h Sun Apr 28 18:14:48 2002 @@ -42,6 +42,14 @@ #ifndef _SYS_TIMES_H_ #define _SYS_TIMES_H_ +#ifndef _KERNEL +#include <sys/cdefs.h> + +__BEGIN_DECLS +clock_t times __P((struct tms *)); +__END_DECLS +#endif + #include <machine/ansi.h> #ifdef _BSD_CLOCK_T_ @@ -56,11 +64,4 @@ clock_t tms_cstime; /* System CPU time of terminated child procs */ }; -#ifndef _KERNEL -#include <sys/cdefs.h> - -__BEGIN_DECLS -clock_t times __P((struct tms *)); -__END_DECLS -#endif #endif /* !_SYS_TIMES_H_ */ --------------050407000506050405020706-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CCC244C.4010601>