Date: Fri, 15 Jul 2005 14:28:31 -0700 From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Harry Coin <harrycoin@qconline.com> Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up Message-ID: <42D82A7F.4050208@root.org> In-Reply-To: <200507121027.14113.jhb@FreeBSD.org> References: <4.3.2.7.2.20050711121036.02caa348@mail.qconline.com> <200507111626.25124.jhb@FreeBSD.org> <42D2F177.3070101@root.org> <200507121027.14113.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Monday 11 July 2005 06:23 pm, Nate Lawson wrote: > >>John Baldwin wrote: >> >>>Also, can you upload your acpidump somewhere and provide a URL? I'm >>>curious if you have ACPI devices like thermal zones that don't have >>>_HID's and only have _CIDs. In fact, here's a patch to fix >>>acpi_get_logicalid() in that case. Give this a try first and let me know >>>if it fixes it. >> >>I would rather you directly call acpi_isa_get_compatid() rather than >>duplicating its logic here. There's no guarantee that the first CID >>will match the single ID passed in. > > > There is no passed in ID. For the common use of this function in almost all > ISA drivers, it just needs to return != 0 for PNP devices. I really think the driver is broken and the API is fine for this. I don't like the hack of returning a random CID for checks against the HID. Drivers down the road may come to rely on this and then every BIOS that has a different order for CIDs becomes a potential breakage point. Drivers should not rely on isa_get_logicalid() to determine a boolean "is PNP?" -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42D82A7F.4050208>