Date: Sat, 29 Nov 2008 23:21:48 -0500 From: Eitan Adler <eitanadlerlist@gmail.com> To: d@delphij.net Cc: freebsd-hackers@freebsd.org Subject: Re: change to ee.c Message-ID: <493214DC.2080904@gmail.com> In-Reply-To: <4932122A.8070209@delphij.net> References: <49320FF7.4040901@gmail.com> <4932122A.8070209@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Xin LI wrote: > Hi, Eitan, > Tanks for interested in this but I'm afraid that your patch is > incorrect. mkstemp returns a file descriptor rather than a string > pointer, therefore, the subsequent open() would have undefined behavior. > It looks like that we actually want fd = mkstemp() here. Thanks. If this is the case how come gcc did not return any warnings? > > Note that we may want to bring vendor fixes before making any changes to > reduce duplicated work... I was not aware that this was a third party program. I'll look around and see if this was fixed. I'm sort of learning C by fixing these minor bugs so any help is appreciated. > > Cheers, - -- Eitan Adler GNU Key fingerptrint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkkyFNwACgkQtl8kq+nCzNGlRgCeJDMfvnR0ZVtz/k/OjDlrKUUP 3xwAniOJpgueqFh3KVKhk7hS9GFE9fqD =gTGT -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?493214DC.2080904>