Date: Wed, 21 Jan 2009 10:26:19 -0500 From: Rick Chisholm <rchisholm@parallel42.ca> To: Guido Falsi <mad@madpilot.net> Cc: ports@FreeBSD.org, Doug Barton <dougb@FreeBSD.org> Subject: Re: FreeBSD Port: squidGuard-1.4 Message-ID: <49773E9B.40802@parallel42.ca> In-Reply-To: <20090121121915.GA89663@megatron.madpilot.net> References: <49763159.2070901@parallel42.ca> <497638D3.1000908@madpilot.net> <4976BC15.3080209@FreeBSD.org> <20090121121915.GA89663@megatron.madpilot.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Guido Falsi wrote:
> On Tue, Jan 20, 2009 at 10:09:25PM -0800, Doug Barton wrote:
>
>> Guido Falsi wrote:
>> > Since ports are expected not to leave files behind when deinstalled,
>>
>>> port logic checks on first install if ${DATADIR} exists. If it does it
>>> will NOT be created/populated and NOT included in the plist, and not
>>> removed on deinstall.
>>>
>>> On the contrary if it does not find such directory it will create,
>>> populate it remove it on deinstall.
>>>
>> The way that this is traditionally handled is for the port to install
>> both file and file.sample, but only list file.sample in the plist.
>> Then at deinstall time there should be a script to compare file to
>> file.sample and remove file if it is the same. Repeat for values of
>> $file as needed.
>>
>> It is not expected or desirable for a port to remove user-modified
>> files (including those files created by a daemon).
>>
>
> I agree. I was thinking if it could be acceptable to add an option to
> the port for installing/not installing the sample blacklists and not
> adding those to the plist anyway. This could be easier to handle.
> Perhaps also more logical.
>
> With this change a note on deinstall to check and remove by hand the
> folder should also be added, obviously.
>
>
That might make more sense, esp. if a user has created numerous large
dbs rather than downloading them from a 3rd party. It wasn't disastrous
for me since I upgraded a test server first, but it would be preferable
if the upgrade didn't touch the db dir or squidGuard.conf.
thanks guys,
Rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49773E9B.40802>