Date: Tue, 31 Aug 2010 17:39:50 -0400 From: jhell <jhell@DataIX.net> To: bf1783@gmail.com Cc: "b. f." <bf1783@googlemail.com>, freebsd-ports@FreeBSD.org Subject: Re: math/blas linking to gfortran with LDADD?= -lgfortran Message-ID: <4C7D76A6.7080401@DataIX.net> In-Reply-To: <AANLkTinhAPY-PEH_TegMAEx1ejHf_WoEL8KZU%2BoXGhFD@mail.gmail.com> References: <AANLkTinhAPY-PEH_TegMAEx1ejHf_WoEL8KZU%2BoXGhFD@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Looking closer at the math/blas & math/lapack ports: This statement does not make any sense. The logic is backwards for every instance. And WITH_PROFILE would do. .if !(defined(NOPROFILE) || defined(NO_PROFILE) || defined(WITHOUT_PROFILE)) PLIST_FILES+= lib/libblas_p.a .endif Which is basically saying: Add that profile lib if NOPROFILE is not defined "_p is a profiled lib why would you want to install this if the admin has NOT defined NOPROFILE? Second add that lib if NO_PROFILE is defined ? see previous question still doing the wrong thing here. Third add that lib if WITHOUT_PROFILE is defined ? see previous two question still not doing the right thing here. Simple following would do. .if (defined(WITH_PROFILE) PLIST_FILES+= lib/libblas_p.a ,endif Then if it is really a concern that this has to default to on, then use the options framework to present that to the user. At least in this instance the user will at least know whats going on. Regards, -- jhell,v
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C7D76A6.7080401>