Date: Sun, 12 Dec 2010 22:52:11 +0200 From: Andriy Gapon <avg@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-multimedia@freebsd.org, Martin Matuska <mm@freebsd.org> Subject: Re: ffmpeg and mmap Message-ID: <4D0535FB.1090102@freebsd.org> In-Reply-To: <20101212204541.GA33073@deviant.kiev.zoral.com.ua> References: <4D05332C.7010208@freebsd.org> <20101212204541.GA33073@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
on 12/12/2010 22:45 Kostik Belousov said the following: > On Sun, Dec 12, 2010 at 10:40:12PM +0200, Andriy Gapon wrote: >> To get around that issue _on Linux_, ffmpeg folks have put explicit >> _SVID_SOURCE definition right into the libswscale/utils.c file: >> #define _SVID_SOURCE //needed for MAP_ANONYMOUS >> >> For much the same reason we need to add the following for FreeBSD (as >> hackish as it is): #define __BSD_VISIBLE 1 >> >> With that addition the code buffer is allocated properly and the code >> in it can be executed. > Applications should never define the symbols from reserved namespace, > in this case __BSD_VISIBLE. Right solution is to not define _POSIX_SOURCE. i agree with you, but I don't know why the ffmpeg folks decided to use _POSIX_C_SOURCE=200112 in the first place and what could break without it. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D0535FB.1090102>