Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Mar 2007 01:21:53 +0900
From:      "Hidetoshi Shimokawa" <simokawa@FreeBSD.ORG>
To:        "Eric Anderson" <anderson@centtech.com>
Cc:        hopet@ics.muni.cz, freebsd-firewire@freebsd.org
Subject:   Re: fwcontrol -R issues with several cameras
Message-ID:  <626eb4530703220921p3f6176efxe2b8085724436afb@mail.gmail.com>
In-Reply-To: <626eb4530703220845qdedffbdod4bd9894dec51e6@mail.gmail.com>
References:  <46028460.5000004@centtech.com> <626eb4530703220718q4d293a16wfbb0a70cf21e624b@mail.gmail.com> <46029A6E.9070000@centtech.com> <626eb4530703220845qdedffbdod4bd9894dec51e6@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Oops, I must be wrong.
Option '-M'  has to be used with '-R' .

On 3/23/07, Hidetoshi Shimokawa <simokawa@freebsd.org> wrote:
> I found a  trivial bug in fwcontrol.c for '-M' option.
>
> RCS file: /home/ncvs/src/usr.sbin/fwcontrol/fwcontrol.c,v retrieving
> revision 1.23
> diff -u -r1.23 fwcontrol.c
> --- fwcontrol.c 26 Oct 2006 22:33:38 -0000      1.23
> +++ fwcontrol.c 22 Mar 2007 15:37:25 -0000
> @@ -764,7 +764,7 @@
>                                 errx(EX_USAGE, "unrecognized method: %s",
>                                     optarg);
>                         }
> -                       break;
> +                       /* fall through */
>                 case 'R':
>                         open_dev(&fd, devbase);
>                         if (recvfn == NULL) /* guess... */
>
> Without this patch,  'fwcontrol -Md' will exit immediately.
> But I am not sure whether this fix your problem.

-- 
/\ Hidetoshi Shimokawa
\/  simokawa@FreeBSD.ORG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?626eb4530703220921p3f6176efxe2b8085724436afb>