Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Jun 1996 15:31:49 -0700
From:      "Jordan K. Hubbard" <jkh@time.cdrom.com>
To:        Nate Williams <nate@mt.sri.com>
Cc:        Scott Blachowicz <scott@statsci.com>, current@freebsd.org
Subject:   Re: Building inside of /usr/src? 
Message-ID:  <7235.835914709@time.cdrom.com>
In-Reply-To: Your message of "Thu, 27 Jun 1996 16:10:13 MDT." <199606272210.QAA11833@rocky.mt.sri.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
> Well, you already took it out, so I guess comments don't matter, but
> there's *probably* a reason for doing it.  You're best bet would be to
> remove it *locally* and then test the change to see if bad things happen
> before spamming the repository making us find all the bugs. :(

I did test it and I carefully followed the logic of the code before
making the commit (that's why the commit followed so quickly - it
became very quickly clear that this behavior was now a bug in the new
system).

There's absolutely *no* reason to ignore the output of getcwd() and it
does check the directory returned for errors / permission problems.

The only thing I can figure out was that someone found AMD's path
mangling to be non-intuitive (though functional) or something and
figured they'd substitite in the value of $PWD.  I can think of no
other reason for it and, in fact, it could easily be argued that they
weren't thinking straight when they made this change as it makes it
far too easy to confuse the bejeezus out of make by using a bogus
shell or setting the value of PWD yourself.

					Jordan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7235.835914709>