Date: Tue, 25 Oct 2011 00:45:05 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Kenneth D. Merry" <ken@freebsd.org> Cc: freebsd-scsi@freebsd.org, Eygene Ryabinkin <rea@freebsd.org> Subject: Re: Looking for a committer for cam fixes / enhancements Message-ID: <7E5239236AA04319B4C090E5F199DC64@multiplay.co.uk> References: <02B04E968B8648CC83F274B32090B937@multiplay.co.uk> <20111024171039.GA39194@nargothrond.kdm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message -----
From: "Kenneth D. Merry" <ken@freebsd.org>
> Thanks for doing these! They seem like they would be very useful.
> Hopefully, once we get trim support plumbed all the way down, it
> won't be necessary to issue the erase manually.
Indeed, would so love to see trim added to zfs :)
> I do have a few comments:
>
> - The patches should be generated against head, since they would be
> committed there first and merged back. (They don't apply cleanly to
> head.)
>
> - There are a number of style issues in the patches:
> - Lines longer than 80 characters
> - Spaces/formatting problems (e.g. at the beginning of
> atasecurity_erase()).
> - The prevailing style of the file isn't followed for line
> continuations. (It isn't always KNF, either.)
>
> - I'm not really a fan of getopt_long. There are lots of password
> arguments, how about turning those into '-p foopasswd=bar' instead?
>
> Anyway, if you could, please address those things and send me the diffs.
Thanks for the feedback. I will get them updated as per comments as
soon as I can.
Could you give me some points on the things you spotted weren't "KNR"
I've tried to stick with what I saw as the current formatting but clearly
missed something's ;-)
Not really a fan myself of mixing in getopt_long either but if beats the
current use of totally random / meaningless letters for options if we
stuck with short opts. Add that to how dangerous the options are and I
think forcing long opts is the right move, what do others think?
Regards
Steve
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7E5239236AA04319B4C090E5F199DC64>