Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Oct 2017 20:05:26 -0700
From:      Mark Millard <markmi@dsl-only.net>
To:        Emmanuel Vadot <manu@bidouilliste.com>, freebsd-arm <freebsd-arm@freebsd.org>
Subject:   Re: svn commit: r324822 - head/sys/modules/dtb/allwinner [removal of sinovoip-bpi-m3.dts from sys/modules/dtb/allwinner/Makefile DTS list]
Message-ID:  <8696CCFA-AE7D-4324-90A8-BB73402FA124@dsl-only.net>
In-Reply-To: <B3F39A7C-339B-4072-9E41-A3F9DA1F590B@dsl-only.net>
References:  <3AD6B1F8-512C-43BB-AC76-7721454AD02F@dsl-only.net> <20171021195812.5bdb902401b8e756b6abfe40@bidouilliste.com> <C9F6BF5E-28DB-4569-B71E-EDE2A042FC78@dsl-only.net> <20171021204356.47e3cd6066144bcd07f46699@bidouilliste.com> <50728566-11C2-45EB-8367-00CAF38D4548@dsl-only.net> <B3F39A7C-339B-4072-9E41-A3F9DA1F590B@dsl-only.net>

next in thread | previous in thread | raw e-mail | index | archive | help
[Reporting what seems to be the case for
/boot/dtb/sinovoip-bpi-m3.dtb old and newer
and, so, its source files (old and newer).]

On 2017-Oct-21, at 4:09 PM, Mark Millard <markmi at dsl-only.net> wrote:

> On 2017-Oct-21, at 2:06 PM, Mark Millard <markmi at dsl-only.net> =
wrote:
>=20
>> On 2017-Oct-21, at 11:43 AM, Emmanuel Vadot <manu at =
bidouilliste.com> wrote:
>>=20
>>> On Sat, 21 Oct 2017 11:26:57 -0700
>>> Mark Millard <markmi at dsl-only.net> wrote:
>>>=20
>>>> On 2017-Oct-21, at 10:58 AM, Emmanuel Vadot <manu at =
bidouilliste.com> wrote:
>>>>=20
>>>>>>> . . .
>>>>=20
>>>> If I understand the current status correctly, the
>>>> recent changes to use upstream DTS materials took
>>>> the BPI-M3 from having, e.g., USB working to USB
>>>> not working. -r323641 removed AWUSBPHY_TYPE_A83T
>>>> from enum awusbphy_type because of what was missing
>>>> from upstream DTS materials and such.
>>>=20
>>> Uses of upstream DTS is active since ~2 years ago.
>>> I think I removed support for USB on A83T because I couldn't test, =
but
>>> maybe the code just work and adding the compatible string again =
might
>>> do it. Feel free to send a patch on phabricator if it does.
>>=20
>> . . .
. . .

Using the .dtb files produced and using
dtc to convert back to .dts files (via
-s for allowing diffs) I get the
following (comparing to -r324743). The
list of types of changes is rather
short (many  instances, mostly not
shown below).

The types of differences may suggest
some about compatibility for going
forward.

# diff -u ~/bpi-m3-sorted*.dts | more
--- /root/bpi-m3-sorted-317015.dts      2017-10-22 01:47:30.424893000 =
-0700
+++ /root/bpi-m3-sorted-324743.dts      2017-10-22 02:17:24.545620000 =
-0700
@@ -7,6 +7,127 @@
        compatible =3D "sinovoip,bpi-m3", "allwinner,sun8i-a83t";
        interrupt-parent =3D <0x1>;
        model =3D "Sinovoip BananaPi M3 v1.2";
+       __local_fixups__ {
+
+               fixup =3D "/cpus/cpu@0:clocks:0";
+               fixup =3D "/cpus/cpu@0:cpu-supply:0";
. . .
+               fixup =3D "/leds/blue_led:gpios:0";
+               fixup =3D "/:interrupt-parent:0";
+       };

(lots of such fixup's) and lots of things like:

-               linux,phandle =3D <0x46>;

as well as some (17?) like:

-               phandle =3D <0x46>;

but other plain phandle's are instead unchanged.

There are 4 'function =3D "gpio_out";' related
differences as well (usb tied):

                        ahci_pwr_pin@0 {
=20
-                               allwinner,drive =3D <0x0>;
-                               allwinner,function =3D "gpio_out";
                                allwinner,pins =3D "PD25";
-                               allwinner,pull =3D <0x0>;
-                               linux,phandle =3D <0x31>;
+                               function =3D "gpio_out";
                                phandle =3D <0x31>;
+                               pins =3D "PB8";
                        };

and later:
                        usb0_vbus_pin@0 {
=20
-                               allwinner,drive =3D <0x0>;
-                               allwinner,function =3D "gpio_out";
-                               allwinner,pins =3D "PB9";
-                               allwinner,pull =3D <0x0>;
-                               linux,phandle =3D <0x32>;
+                               function =3D "gpio_out";
                                phandle =3D <0x32>;
+                               pins =3D "PB9";
                        };
                        usb1_vbus_pin@0 {
=20
-                               allwinner,drive =3D <0x0>;
-                               allwinner,function =3D "gpio_out";
                                allwinner,pins =3D "PD24";
-                               allwinner,pull =3D <0x0>;
-                               linux,phandle =3D <0x33>;
+                               function =3D "gpio_out";
                                phandle =3D <0x33>;
+                               pins =3D "PH6";
                        };
                        usb2_vbus_pin@0 {
=20
-                               allwinner,drive =3D <0x0>;
-                               allwinner,function =3D "gpio_out";
-                               allwinner,pins =3D "PH3";
-                               allwinner,pull =3D <0x0>;
-                               linux,phandle =3D <0x34>;
+                               function =3D "gpio_out";
                                phandle =3D <0x34>;
+                               pins =3D "PH3";
                        };

[Note the 'allwinner,pins =3D "PD25";' and the
'allwinner,pins =3D "PD24";' that were not deleted
when other "allwinner,pins" lines were deleted.]

And that is it for types of sinovoip-bpi-m3.dtb
changes as of -r324743 .

I do not know if any of that suggests a .dtb
handling incompatibility for going forward.

As near as I can tell:

/boot/dtb/sinovoip-bpi-m3.dtb

content is irrelevant to u-boot and
to ubldr, removing one of my worries.

[The above is my first use of dtc as far as I
remember. Interesting.]

=3D=3D=3D
Mark Millard
markmi at dsl-only.net




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8696CCFA-AE7D-4324-90A8-BB73402FA124>