Date: Tue, 24 Apr 2007 21:19:15 -0700 From: "Josh Carroll" <josh.carroll@gmail.com> To: "Thomas Quinot" <thomas@freebsd.org> Cc: freebsd-scsi@freebsd.org, bug-followup@freebsd.org, c47g@gmx.at Subject: Re: kern/103602: drive gets wedged on READ CD CAPACITY if no disc is in Message-ID: <8cb6106e0704242119h4a09d7d4v667d64071b3bd053@mail.gmail.com> In-Reply-To: <8cb6106e0704241845r737dca05p50fc967a61d66677@mail.gmail.com> References: <8cb6106e0703261318o120c620ar6b2461802632fc01@mail.gmail.com> <460AA9E3.4030106@samsco.org> <8cb6106e0703281531k4c5bebecp5566c64c8f458a74@mail.gmail.com> <8cb6106e0704030039if46397fvfc993d9c9e19e1fc@mail.gmail.com> <8cb6106e0704032107w457026b1t1e04ed11008af48a@mail.gmail.com> <20070424162008.GA7087@melamine.cuivre.fr.eu.org> <8cb6106e0704240929j38178df6k1b6391446c69a2ae@mail.gmail.com> <20070424165843.GD7087@melamine.cuivre.fr.eu.org> <8cb6106e0704241132vfa6b312s3b4cbea0c823b796@mail.gmail.com> <8cb6106e0704241845r737dca05p50fc967a61d66677@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_169176_7582099.1177474755826 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline I used the following patch (attached) against a RELENG_6_2 src tree, and it's working brilliantly. No problems to speak of. I can boot with atapicam in the kernel without a disk in the drive and there were no hangs at all. The sg_readcap command still gives (immediately): READ CAPACITY (10) failed, device not ready I was able to burn a DVD-R with growisofs and blank and burn a CD-RW with cdrecord. So all seems well, though I'll continue to keep an eye on it. I'm not sure which patches need to be committed, etc. But I wanted to include the cumulative patch against the 6.2-R src in case it helps you decide which code to commit to -CURRENT/etc. Christian - can you give the attached patch a shot if you've got a 6.2-R kernel/install handy on your P5B-E? Thanks for all your help Thomas! Josh ------=_Part_169176_7582099.1177474755826 Content-Type: application/octet-stream; name=RELENG_6_2.atapicam.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_f0x9z6p0 Content-Disposition: attachment; filename="RELENG_6_2.atapicam.patch" ZGlmZiAtdXJOIHN5cy5vbGQvY2FtL2NhbV94cHQuYyBzeXMvY2FtL2NhbV94cHQuYwotLS0gc3lz Lm9sZC9jYW0vY2FtX3hwdC5jCVNhdCBTZXAgMjMgMTE6NDI6MDggMjAwNgorKysgc3lzL2NhbS9j YW1feHB0LmMJVHVlIEFwciAyNCAxMzozMToyOCAyMDA3CkBAIC0yNTQsNiArMjU0LDExIEBACiBz dGF0aWMgc3RydWN0IHhwdF9xdWlya19lbnRyeSB4cHRfcXVpcmtfdGFibGVbXSA9IAogewogCXsK KwkJLyogSGFuZ3Mgb24gSU5RVUlSWSB3aXRoIEVWUEQgZmxhZz8/PyAqLworCQl7IFRfQ0RST00s IFNJUF9NRURJQV9SRU1PVkFCTEUsIHNvbnksICJEVkQgUlcgRFJVKiIsICIqIiB9LAorCQlDQU1f UVVJUktfTk9TRVJJQUwsIC8qbWludGFncyovMCwgLyptYXh0YWdzKi8wCisJfSwKKwl7CiAJCS8q IFJlcG9ydHMgUVVFVUUgRlVMTCBmb3IgdGVtcG9yYXJ5IHJlc291cmNlIHNob3J0YWdlcyAqLwog CQl7IFRfRElSRUNULCBTSVBfTUVESUFfRklYRUQsIHF1YW50dW0sICJYUDM5MTAwKiIsICIqIiB9 LAogCQkvKnF1aXJrcyovMCwgLyptaW50YWdzKi8yNCwgLyptYXh0YWdzKi8zMgpkaWZmIC11ck4g c3lzLm9sZC9jYW0vc2NzaS9zY3NpX2NkLmMgc3lzL2NhbS9zY3NpL3Njc2lfY2QuYwotLS0gc3lz Lm9sZC9jYW0vc2NzaS9zY3NpX2NkLmMJV2VkIEp1bCAyNiAwMDo0ODo1MSAyMDA2CisrKyBzeXMv Y2FtL3Njc2kvc2NzaV9jZC5jCVR1ZSBBcHIgMjQgMTM6MzE6MjggMjAwNwpAQCAtMTA3LDkgKzEw NywxMCBAQAogfSBjZF9mbGFnczsKIAogdHlwZWRlZiBlbnVtIHsKLQlDRF9DQ0JfUFJPQkUJCT0g MHgwMSwKLQlDRF9DQ0JfQlVGRkVSX0lPCT0gMHgwMiwKLQlDRF9DQ0JfV0FJVElORwkJPSAweDAz LAorCUNEX0NDQl9QUk9CRV9UVVIJPSAweDAxLAorCUNEX0NDQl9QUk9CRV9SQ0FQCT0gMHgwMiwK KwlDRF9DQ0JfQlVGRkVSX0lPCT0gMHgwMywKKwlDRF9DQ0JfV0FJVElORwkJPSAweDA0LAogCUNE X0NDQl9UWVBFX01BU0sJPSAweDBGLAogCUNEX0NDQl9SRVRSWV9VQQkJPSAweDEwCiB9IGNkX2Nj Yl9zdGF0ZTsKQEAgLTEzNSw3ICsxMzYsOCBAQAogfTsKIAogdHlwZWRlZiBlbnVtIHsKLQlDRF9T VEFURV9QUk9CRSwKKwlDRF9TVEFURV9QUk9CRV9SQ0FQLAorCUNEX1NUQVRFX1BST0JFX1RVUiwK IAlDRF9TVEFURV9OT1JNQUwKIH0gY2Rfc3RhdGU7CiAKQEAgLTY3NSw3ICs2NzcsNyBAQAogCWJ6 ZXJvKHNvZnRjLCBzaXplb2YoKnNvZnRjKSk7CiAJTElTVF9JTklUKCZzb2Z0Yy0+cGVuZGluZ19j Y2JzKTsKIAlTVEFJTFFfSU5JVCgmc29mdGMtPm1vZGVfcXVldWUpOwotCXNvZnRjLT5zdGF0ZSA9 IENEX1NUQVRFX1BST0JFOworCXNvZnRjLT5zdGF0ZSA9IENEX1NUQVRFX1BST0JFX1RVUjsKIAli aW9xX2luaXQoJnNvZnRjLT5iaW9fcXVldWUpOwogCWlmIChTSURfSVNfUkVNT1ZBQkxFKCZjZ2Qt PmlucV9kYXRhKSkKIAkJc29mdGMtPmZsYWdzIHw9IENEX0ZMQUdfRElTQ19SRU1PVkFCTEU7CkBA IC0xNTYxLDcgKzE1NjMsMjEgQEAKIAkJfQogCQlicmVhazsKIAl9Ci0JY2FzZSBDRF9TVEFURV9Q Uk9CRToKKwljYXNlIENEX1NUQVRFX1BST0JFX1RVUjoKKwl7CisJCWNzaW8gPSAmc3RhcnRfY2Ni LT5jc2lvOworCQlzY3NpX3Rlc3RfdW5pdF9yZWFkeShjc2lvLAorCQkJCSAgICAgLypyZXRyaWVz Ki80LAorCQkJCSAgICAgY2Rkb25lLAorCQkJCSAgICAgTVNHX1NJTVBMRV9RX1RBRywKKwkJCQkg ICAgIFNTRF9GVUxMX1NJWkUsCisJCQkJICAgICAvKnRpbWVvdXQqLzEwMDAwKTsKKwkJc3RhcnRf Y2NiLT5jY2JfaC5jY2JfYnAgPSBOVUxMOworCQlzdGFydF9jY2ItPmNjYl9oLmNjYl9zdGF0ZSA9 IENEX0NDQl9QUk9CRV9UVVI7CisJCXhwdF9hY3Rpb24oc3RhcnRfY2NiKTsKKwkJYnJlYWs7CisJ fQorCWNhc2UgQ0RfU1RBVEVfUFJPQkVfUkNBUDoKIAl7CiAKIAkJcmNhcCA9IChzdHJ1Y3Qgc2Nz aV9yZWFkX2NhcGFjaXR5X2RhdGEgKiltYWxsb2Moc2l6ZW9mKCpyY2FwKSwKQEAgLTE1ODIsNyAr MTU5OCw3IEBACiAJCQkJICAgU1NEX0ZVTExfU0laRSwKIAkJCQkgICAvKnRpbWVvdXQqLzIwMDAw KTsKIAkJc3RhcnRfY2NiLT5jY2JfaC5jY2JfYnAgPSBOVUxMOwotCQlzdGFydF9jY2ItPmNjYl9o LmNjYl9zdGF0ZSA9IENEX0NDQl9QUk9CRTsKKwkJc3RhcnRfY2NiLT5jY2JfaC5jY2Jfc3RhdGUg PSBDRF9DQ0JfUFJPQkVfUkNBUDsKIAkJeHB0X2FjdGlvbihzdGFydF9jY2IpOwogCQlicmVhazsK IAl9CkBAIC0xNjczLDcgKzE2ODksMzUgQEAKIAkJYmlvZmluaXNoKGJwLCBOVUxMLCAwKTsKIAkJ YnJlYWs7CiAJfQotCWNhc2UgQ0RfQ0NCX1BST0JFOgorCWNhc2UgQ0RfQ0NCX1BST0JFX1RVUjoK Kwl7CisJCWlmICgoZG9uZV9jY2ItPmNjYl9oLnN0YXR1cyAmIENBTV9TVEFUVVNfTUFTSykgPT0g Q0FNX1JFUV9DTVApIHsKKwkJCXNvZnRjLT5zdGF0ZSA9IENEX1NUQVRFX1BST0JFX1JDQVA7CisJ CQl4cHRfcmVsZWFzZV9jY2IoZG9uZV9jY2IpOworCQkJeHB0X3NjaGVkdWxlKHBlcmlwaCwgLypw cmlvcml0eSovNSk7CisJCQlyZXR1cm47CisJCX0KKwkJaWYgKChkb25lX2NjYi0+Y2NiX2guc3Rh dHVzICYgQ0FNX0RFVl9RRlJaTikgIT0gMCkgeworCQkJLyogRG9uJ3Qgd2VkZ2UgdGhlIHF1ZXVl ICovCisJCQljYW1fcmVsZWFzZV9kZXZxKGRvbmVfY2NiLT5jY2JfaC5wYXRoLAorCQkJCQkgLypy ZWxzaW1fZmxhZ3MqLzAsCisJCQkJCSAvKnJlZHVjdGlvbiovMCwKKwkJCQkJIC8qdGltZW91dCov MCwKKwkJCQkJIC8qZ2V0Y291bnRfb25seSovMCk7CisJCX0KKwkJaWYgKGJvb3R2ZXJib3NlKQor CQkJY2FtX2Vycm9yX3ByaW50KGRvbmVfY2NiLCBDQU1fRVNGX0FMTCwgQ0FNX0VQRl9BTEwpOwor CQkvKgorCQkgKiBUaGUgVFVSIGdlbmVyYXRlZCBhbiBlcnJvciwgc28gdGhlcmUgbGlrZWx5IGlz bid0IG1lZGlhIGluCisJCSAqIHRoZSBkcml2ZS4gIFNvbWUgZHJpdmVzIGxvY2sgdXAgaWYgdGhl eSBhcmUgc2VudCBhIHJlYWQKKwkJICogY2FwYWNpdHkgY29tbWFuZCB3aGlsZSBpbiB0aGlzIHN0 YXRlLCBzbyBhdm9pZCBkb2luZyB0aGF0LgorCQkgKi8KKwkJc29mdGMtPnN0YXRlID0gQ0RfU1RB VEVfTk9STUFMOworCQl4cHRfcmVsZWFzZV9jY2IoZG9uZV9jY2IpOworCQljYW1fcGVyaXBoX3Vu bG9jayhwZXJpcGgpOworCQlyZXR1cm47CisJfQorCWNhc2UgQ0RfQ0NCX1BST0JFX1JDQVA6CiAJ ewogCQlzdHJ1Y3QJICAgc2NzaV9yZWFkX2NhcGFjaXR5X2RhdGEgKnJkY2FwOwogCQljaGFyCSAg IGFubm91bmNlX2J1ZlsxMjBdOyAvKgpkaWZmIC11ck4gc3lzLm9sZC9kZXYvYXRhL2F0YXBpLWNh bS5jIHN5cy9kZXYvYXRhL2F0YXBpLWNhbS5jCi0tLSBzeXMub2xkL2Rldi9hdGEvYXRhcGktY2Ft LmMJVHVlIEFwciAgNCAwOTowNzo0MiAyMDA2CisrKyBzeXMvZGV2L2F0YS9hdGFwaS1jYW0uYwlU dWUgQXByIDI0IDEzOjMxOjIyIDIwMDcKQEAgLTUwNSwxMCArNTA1LDEwIEBACiAKIAlzd2l0Y2gg KGNjYl9oLT5mbGFncyAmIENBTV9ESVJfTUFTSykgewogCWNhc2UgQ0FNX0RJUl9JTjoKLQkgICAg IHJlcXVlc3RfZmxhZ3MgfD0gQVRBX1JfUkVBRHxBVEFfUl9ETUE7CisJICAgICByZXF1ZXN0X2Zs YWdzIHw9IEFUQV9SX1JFQUQ7CiAJICAgICBicmVhazsKIAljYXNlIENBTV9ESVJfT1VUOgotCSAg ICAgcmVxdWVzdF9mbGFncyB8PSBBVEFfUl9XUklURXxBVEFfUl9ETUE7CisJICAgICByZXF1ZXN0 X2ZsYWdzIHw9IEFUQV9SX1dSSVRFOwogCSAgICAgYnJlYWs7CiAJY2FzZSBDQU1fRElSX05PTkU6 CiAJICAgICAvKiBObyBmbGFncyBuZWVkIHRvIGJlIHNldCAqLwpAQCAtNTE3LDggKzUxNyw2IEBA CiAJICAgICBkZXZpY2VfcHJpbnRmKHNvZnRjLT5kZXYsICJ1bmtub3duIElPIG9wZXJhdGlvblxu Iik7CiAJICAgICBnb3RvIGFjdGlvbl9pbnZhbGlkOwogCX0KLQlpZiAoc29mdGMtPmF0YWRldlt0 aWRdLT5tb2RlIDwgQVRBX0RNQSkKLQkgICAgcmVxdWVzdF9mbGFncyAmPSB+QVRBX1JfRE1BOwog CiAJaWYgKChoY2IgPSBhbGxvY2F0ZV9oY2Ioc29mdGMsIHVuaXQsIGJ1cywgY2NiKSkgPT0gTlVM TCkgewogCSAgICBwcmludGYoImNhbm5vdCBhbGxvY2F0ZSBBVEFQSS9DQU0gaGNiXG4iKTsKQEAg LTU4MCw3ICs1NzgsMjMgQEAKIAkgICAgcmVxdWVzdC0+dS5hdGFwaS5jY2JbM10gPSByZXF1ZXN0 LT51LmF0YXBpLmNjYlsxXSAmIDB4MWY7CiAJICAgIHJlcXVlc3QtPnUuYXRhcGkuY2NiWzJdID0g MDsKIAkgICAgcmVxdWVzdC0+dS5hdGFwaS5jY2JbMV0gPSAwOworCisJY2FzZSBSRUFEXzEwOgor CSAgICAvKiBGQUxMVEhST1VHSCAqLworCWNhc2UgV1JJVEVfMTA6CisJICAgIC8qIEZBTExUSFJP VUdIICovCisJY2FzZSBSRUFEXzEyOgorCSAgICAvKiBGQUxMVEhST1VHSCAqLworCWNhc2UgV1JJ VEVfMTI6CisJICAgIC8qCisJICAgICAqIEVuYWJsZSBETUEgKGlmIHRhcmdldCBzdXBwb3J0cyBp dCkgZm9yIFJFQUQgYW5kIFdSSVRFIGNvbW1hbmRzCisJICAgICAqIG9ubHksIGFzIHNvbWUgY29t YmluYXRpb25zIG9mIGRyaXZlLCBjb250cm9sbGVyIGFuZCBjaGlwc2V0IGRvCisJICAgICAqIG5v dCBiZWhhdmUgY29ycmVjdGx5IHdoZW4gRE1BIGlzIGVuYWJsZWQgZm9yIG90aGVyIGNvbW1hbmRz LgorCSAgICAgKi8KKwkgICAgaWYgKHNvZnRjLT5hdGFkZXZbdGlkXS0+bW9kZSA+PSBBVEFfRE1B KQorCQlyZXF1ZXN0X2ZsYWdzIHw9IEFUQV9SX0RNQTsKIAkgICAgYnJlYWs7CisKIAl9CiAKIAlp ZiAoKGNjYl9oLT5mbGFncyAmIENBTV9ESVJfTUFTSykgPT0gQ0FNX0RJUl9JTiAmJiAobGVuICYg MSkpIHsKQEAgLTc0Niw3ICs3NjAsOSBAQAogICAgIGZyZWVfaGNiKGhjYik7CiAgICAgY2NiLT5j Y2JfaC5zdGF0dXMgPQogCXN0YXR1cyB8IChjY2ItPmNjYl9oLnN0YXR1cyAmIH4oQ0FNX1NUQVRV U19NQVNLIHwgQ0FNX1NJTV9RVUVVRUQpKTsKKyAgICBtdHhfbG9jaygmR2lhbnQpOwogICAgIHhw dF9kb25lKGNjYik7CisgICAgbXR4X3VubG9jaygmR2lhbnQpOwogfQogCiBzdGF0aWMgdm9pZAo= ------=_Part_169176_7582099.1177474755826--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8cb6106e0704242119h4a09d7d4v667d64071b3bd053>