Date: Thu, 18 Nov 2010 09:18:39 -0800 From: Rob Farmer <rfarmer@predatorlabs.net> To: Eir Nym <eirnym@gmail.com> Cc: ports@freebsd.org, Jason Helfman <jhelfman@e-e.com> Subject: Re: Mk/bsd.command.mk: missing CSH tag Message-ID: <AANLkTi=N=aG5=swOLjCL0041SZfhq501tE047Rg_H44G@mail.gmail.com> In-Reply-To: <AANLkTimkLmZNVWE1XG4vekHtYYrWWRk9-Jq8shJVdze1@mail.gmail.com> References: <4CE5280E.3090009@zedat.fu-berlin.de> <AANLkTin5v4NDNQyYDBCJ=r0OUo33vSqLF5a6rYCZQaS2@mail.gmail.com> <20101118160804.GA73849@eggman.experts-exchange.com> <AANLkTimkLmZNVWE1XG4vekHtYYrWWRk9-Jq8shJVdze1@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 18, 2010 at 08:13, Eir Nym <eirnym@gmail.com> wrote: > On 18 November 2010 19:08, Jason Helfman <jhelfman@e-e.com> wrote: >> Wrote a quick patch: >> --- bsd.commands.mk.orig =A0 =A0 =A0 =A02010-11-18 08:05:47.000000000 -0= 800 >> +++ bsd.commands.mk =A0 =A0 2010-11-18 08:06:17.000000000 -0800 >> @@ -76,6 +76,7 @@ >> =A0SED?=3D =A0 =A0 =A0 =A0 =A0/usr/bin/sed >> =A0SETENV?=3D =A0 =A0 =A0 /usr/bin/env >> =A0SH?=3D =A0 =A0 =A0 =A0 =A0 /bin/sh >> +CSH?=3D =A0 =A0 =A0 =A0 =A0/bin/csh >> =A0SORT?=3D =A0 =A0 =A0 =A0 /usr/bin/sort >> =A0STRIP_CMD?=3D =A0 =A0/usr/bin/strip >> =A0# Command to run commands as privileged user >> The patch should probably retain alphabetical order. > > Your patch should check if tcsh is in system. it is optional component. Why? What do you suggest happens if it isn't found? Nothing will break except stuff that uses the variable and it would use the variable because it needs csh. It is part of the base system (/bin/csh and /bin/tcsh) for all supported releases. --=20 Rob Farmer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=N=aG5=swOLjCL0041SZfhq501tE047Rg_H44G>