Date: Sun, 5 Dec 2010 21:34:22 -0500 From: Eitan Adler <lists@eitanadler.com> To: freebsd ports <freebsd-ports@freebsd.org> Subject: [patch] Re: A few questions about bsd.port.mk Message-ID: <AANLkTim3SpdVfuT1uNuAkkPe1LgwswfcGmXTa0j_3CZG@mail.gmail.com> In-Reply-To: <AANLkTi=fX4YsGdF=YatWFNzsrgkvD5QK0GDg%2Bdzukv9k@mail.gmail.com> References: <AANLkTi=fX4YsGdF=YatWFNzsrgkvD5QK0GDg%2Bdzukv9k@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 2, 2010 at 5:49 PM, Eitan Adler <lists@eitanadler.com> wrote: > I noticed a line in bsd.port.mk "Kludge for pre-3.0 systems" > > # Kludge for pre-3.0 ystems > MACHINE_ARCH?=3D =C2=A0 =C2=A0 =C2=A0 i386 > > According to cvs blame asami@ added both lines in revision 1.306 in 1999 > > Furthermore in bsd.port.mk it says ports should test against ARCH and > not MACHINE_ARCH > but bsd.port.subdir.mk uses MACHINE_ARCH on line 209. > > bsd.gnustep.mk has a similar test for MACHINE_ARCH instead of ARCH on > line 136 (r1.1 by dinoex) > > 1) Should the initial line be removed > 2) Should bsd.port.subdir.mk be changed to use ARCH instead? > 3) Should bsd.gnustep.mk be changed to use ARCH instead? Here is a completely untested patch that makes the changes above. http://isis.poly.edu/~eitan/files/remove-2004-hack.patch Comments on both the patch and my questions are appreciated. --=20 Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim3SpdVfuT1uNuAkkPe1LgwswfcGmXTa0j_3CZG>