Date: Wed, 21 Oct 2009 16:41:46 -0700 From: "Li, Qing" <qing.li@bluecoat.com> To: "Qing Li" <qingli@freebsd.org>, "Ryan Stone" <rysto32@gmail.com> Cc: freebsd-current@freebsd.org, "b. f." <bf1783@googlemail.com> Subject: RE: svn commit: r198306 - head/sys/net Message-ID: <B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com> In-Reply-To: <9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com> References: <d873d5be0910201621h768e126dq34df38c07b83fe47@mail.gmail.com><bc2d970910201734o332582ceic30fb7e42e14c812@mail.gmail.com><d873d5be0910201900w67833e83kf53b556e2b5c8d00@mail.gmail.com><bc2d970910202030u2c03571etb6379cf29260617d@mail.gmail.com> <9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I reviewed the SMP code and architecture modules last night. After = discussion=20 with Kip Macy, we feel using the "#ifdef SMP" is actually not necessary=20 here.=20 There is one more function in the flow-table module needs to check for = the=20 smp_started condition, but other than that, I don't intend to fix = anything=20 else at this point. -- Qing >=20 > b.f., >=20 > I think you are right in saying those code blocks should > have "#ifdef SMP" condition around them. I am in the > process of make those changes. >=20 > Thanks, >=20 > -- Qing >=20 > On Tue, Oct 20, 2009 at 8:30 PM, Ryan Stone <rysto32@gmail.com> wrote: > > Judging from the checkin comment, it is not intended to only > eliminate > > the call to sched_bind in the non-SMP case. =A0However. you asked > > whether it would work correctly in the non-SMP case and I answered > > that question. > > > > Ryan > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current- > unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B583FBF374231F4A89607B4D08578A4305AE913E>