Date: Thu, 23 Jun 2011 11:41:17 +0400 From: "Ilya A. Arkhipov" <micro@heavennet.ru> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Chris Rees <crees@freebsd.org>, ports@freebsd.org, Ion-Mihai Tetcu <itetcu@freebsd.org>, Joe Marcus Clarke <marcus@freebsd.org>, kwm@freebsd.org Subject: Re: portlint(1) knobs order: let's make things more logical Message-ID: <BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg@mail.gmail.com> In-Reply-To: <20110623033052.GA23118@FreeBSD.org> References: <20110621214013.6cc4760e@heavennet.ru> <20110622020048.GA83940@FreeBSD.org> <BANLkTi=En%2B7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com> <20110622064224.GB94185@FreeBSD.org> <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com> <20110622160233.8b6156e1.itetcu@FreeBSD.org> <20110622135941.GA99725@FreeBSD.org> <e645505a-06bd-461d-b4a6-3f4436caef24@email.android.com> <BANLkTim%2B46u3H9tUp-EqS1PKKtfKZ2KQTw@mail.gmail.com> <20110623033052.GA23118@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
23 =C9=C0=CE=D1 2011 =C7. 7:30 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 Alexey = Dokuchaev <danfe@freebsd.org>=CE=C1=D0=C9=D3=C1=CC: > On Wed, Jun 22, 2011 at 11:39:54PM +0400, Ilya A. Arkhipov wrote: > > Hi danfe@ > > > > http://micro.heavennet.ru/ports/portlint/portlint.patch > > please see it? > > thanks, seems to work fine. I've beautified it a bit (see attach; sectio= ns > become badly numbered and some whitespace nits). marcus@ is CCed. > > I'm not sure if we need to check/enforce any specific order of auxiliarly > LICENSE_ knobs (LICENSE_PERMS, LICENSE_GROUPS, LICENSE_NAME, LICENSE_FILE= , > LICENSE_TEXT). > > ./danfe > Hi danfe@ marcus@ if I've got it right for group we need have specific order + &checkorder('LICENSE', $tmp, $file, qw( +LICENSE LICENSE_COMB LICENSE_PERMS LICENSE_GROUPS +LICENSE_NAME LICENSE_FILE LICENSE_TEXT+ )); what you say if we do that? --=20 Best regards. Ilya A. Arkhipov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg>