Date: Sun, 26 Jun 2011 12:16:24 +0400 From: "Ilya A. Arkhipov" <micro@heavennet.ru> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: Chris Rees <crees@freebsd.org>, ports@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Ion-Mihai Tetcu <itetcu@freebsd.org>, kwm@freebsd.org Subject: Re: portlint(1) knobs order: let's make things more logical Message-ID: <BANLkTimtJAZU7CwYcoGgABPHWQ%2BnfqPXHg@mail.gmail.com> In-Reply-To: <BANLkTinoPey7Y-V_RCqh631whPiiJYxScQ@mail.gmail.com> References: <20110622020048.GA83940@FreeBSD.org> <BANLkTi=En%2B7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com> <20110622064224.GB94185@FreeBSD.org> <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com> <20110622160233.8b6156e1.itetcu@FreeBSD.org> <20110622135941.GA99725@FreeBSD.org> <e645505a-06bd-461d-b4a6-3f4436caef24@email.android.com> <BANLkTim%2B46u3H9tUp-EqS1PKKtfKZ2KQTw@mail.gmail.com> <20110623033052.GA23118@FreeBSD.org> <BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg@mail.gmail.com> <20110623083351.GA51681@FreeBSD.org> <BANLkTin3McVv=8f7LAr_KFUJxNbn-ncw4g@mail.gmail.com> <BANLkTikqeYV2Asg02%2BpvkGf3inW9yCVqBg@mail.gmail.com> <4E052ADA.8050200@freebsd.org> <BANLkTinoPey7Y-V_RCqh631whPiiJYxScQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
25 =C9=C0=CE=D1 2011 =C7. 15:52 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 Ilya A= . Arkhipov <micro@heavennet.ru>=CE=C1=D0=C9=D3=C1=CC: > > > 25 =C9=C0=CE=D1 2011 =C7. 4:24 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 Joe M= arcus Clarke <marcus@freebsd.org>=CE=C1=D0=C9=D3=C1=CC: > > On 6/24/11 8:16 AM, Ilya A. Arkhipov wrote: >> > 23 =C9=C0=CE=D1 2011 =C7. 21:52 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 I= lya A. Arkhipov <micro@heavennet.ru >> >=CE=C1=D0=C9=D3=C1=CC: >> > >> >> =F3=F3: to eitan@eitanadler.com >> > >> > >> > Hi danfe@, marcus@ and all >> > >> > What you say about this patch(in attach)? >> > >> > ps. sorry i can't test patch on my work >> >> Thanks. Can you submit this as a PR so I can track it. I have a >> portlint commit coming up soon. >> >> Joe >> >> -- >> Joe Marcus Clarke >> FreeBSD GNOME Team :: gnome@FreeBSD.org >> FreeNode / #freebsd-gnome >> http://www.FreeBSD.org/gnome >> > > All patch have error's... > if we use "&checkorder('LICENSE', $tmp, $file," that this block invariabl= e, > but there is no license at all. > Also if try: > print "OK: checking fourth section of $file (LICENSE).\n" > if ($verbose); > $tmp =3D $sections[$idx]; > > if ($tmp =3D~ /LICENSE/) { > > &checkorder('LICENSE', $tmp, $file, qw( > LICENSE LICENSE_COMB LICENSE_GROUPS LICENSE_NAME > > LICENSE_TEXT LICENSE_FILE LICENSE_PERMS > )); > $tmp may not contain license example: > 13 MAINTAINER=3D ports@FreeBSD.org > 14 COMMENT=3D Versatile softsynth implemented as a DSSI plugin > 15 > 16 BUILD_DEPENDS=3D ${LOCALBASE}/include/dssi.h:${PORTSDIR}/audio/dssi= \ > 17 ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa > 18 LIB_DEPENDS=3D dssialsacompat.0:${PORTSDIR}/audio/libdssialsacomp= at \ > 19 lo.7:${PORTSDIR}/audio/liblo \ > 20 jack.0:${PORTSDIR}/audio/jack \ > 21 fftw3f.5:${PORTSDIR}/math/fftw3-float > 22 > 23 LICENSE=3D GPLv2 LGPL21 > > Any ideas.. > > > -- > Best regards. > Ilya A. Arkhipov > > Hi All, Please test this patch http://micro.heavennet.ru/ports/portlint/portlint.patch --=20 Best regards. Ilya A. Arkhipov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimtJAZU7CwYcoGgABPHWQ%2BnfqPXHg>