Date: Wed, 10 Dec 2014 15:10:57 -0800 From: Warner Losh <imp@bsdimp.com> To: Zbigniew Bodek <zbb@semihalf.com> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org> Subject: Re: Minor fixes to PL011 UART Message-ID: <BE44C51E-DA0C-4871-9D6F-EA0BAEF1F77A@bsdimp.com> In-Reply-To: <CAG7dG%2BzAwmysuygugEh1mB767KPw5n1UB1YnotPSCdozcFC_yQ@mail.gmail.com> References: <CAG7dG%2BzAwmysuygugEh1mB767KPw5n1UB1YnotPSCdozcFC_yQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 10, 2014, at 2:14 PM, Zbigniew Bodek <zbb@semihalf.com> wrote: >=20 > <0001-Fix-some-obvious-mistakes-in-ARM-PL011-UART.patch> This looks good to me, assuming that the busy bit you are testing is = well defined for all implementations of pl011. I=E2=80=99d consider = adding the uart_barrier, but it isn=E2=80=99t critical. Warner --Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUiNMCAAoJEGwc0Sh9sBEAHgEP+wXXsf1KsikCnJGWTM2juCvL zN/kR1uQrOLP2oAOUti5x8gBvX9k35JITPmcXrUp+q4EcLRRUWwzrzsuB15U+y1w +IDsbJ7Ixz/zMLRi+IUltKVLSa+58Xj0ovC7vNDikYhDefcnUDeXKg6yGv5hQWOg UrEfOMg5Z5yJkIRh1N3ct5mA4+1CU2f5csBucZYS3ss9YWBb7AnrZ8P6vJQVL9vx U0l158/GKVDirRY8XIrdnYyB1d7VMD1/uGj3UXI1+Kv16Z7JeSo4U9jeSQ0IqNki xLZnxPdh1GRUFoFHXpOly7HCrMG1VBDiFdqib6BhwOdcofnI+uRL9hjlypu23dQW e4K5aVTBgg96vrD7Na0a6UVeEKlERTPdg+dzHo/NnqN0Zj0ytKIipasBL11ZwgHR 7A3XnAR//n0M0WI/6c86FoGnb6X5WuDscBLQbuwT3Ik+KbN3QK8/7apLuqtW4SZg bF+lZUEPeoySk12w3jJNhYmWNTMLddxqa48atc3AO+PkqnZVw/gkrwhFPlz8Yrly FhXpHwT7ZlhbPWiFwgc2WYwWJFLg7KdbMmPYdGGolV5MZ3xmdcmNYP8cZ3wito51 dYJdb7axsWu7NeRadSkbQmbFA7IO05j3b40KE1D/AowWvONBt/ju61o4Zmc8p79i X0SfUdpwnDkOHTfmcC+o =5odH -----END PGP SIGNATURE----- --Apple-Mail=_310C6935-4283-43A8-9752-ECC0BB94C41F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BE44C51E-DA0C-4871-9D6F-EA0BAEF1F77A>