Date: Sun, 21 Jun 2009 15:17:46 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp Message-ID: <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org> In-Reply-To: <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Jun 2009, at 15:08, Rui Paulo wrote: > On 21 Jun 2009, at 12:20, Michael wrote: > >> Hello, >> >> I wrote two new acpi modules last year and finally found the time >> to fix >> them, add some missing features and write man pages. > > Michael, this is great work! I'll review and see if we can ship it > with 8.0! Michael, this looks good, but there are two style nits that we need to fix. * we should try not going over the 80 column mark * add a empty new line before every return If you could send me a new patch for 8.0 with these fixes, I'll commit it (unless someone else has objections). Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D>