Date: Mon, 16 Dec 2013 07:56:39 +0800 From: Howard Su <howard0su@gmail.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: [PATCH] Add stack unwind support for the functions in .ko Message-ID: <CAAvnz_qmn%2Ba%2B-aE4GkYw6TDOPzfST2j5WGvHqKX4WWVsVACSzQ@mail.gmail.com> In-Reply-To: <20131215173042.0dead636@bender.Home> References: <CAAvnz_pWZqw-HEB-GTJ_CkErjXrz3v7ozabMXE__vr=SfkBVSg@mail.gmail.com> <CAAvnz_p2vw9=HWbGPePKm_yDxM-bM1h6VaQBeJq9sYXPRb2-Lg@mail.gmail.com> <20131215173042.0dead636@bender.Home>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, December 16, 2013, Andrew Turner wrote: > On Mon, 9 Dec 2013 22:44:14 +0800 > Howard Su <howard0su@gmail.com <javascript:;>> wrote: > > > Here is a new version which solve the unreadable $a problem. (the fix > > is in ddb/db_main.c in the end of the patch.) > > > > I attached the diff for review. > > I can't comment on the MD parts of the code, but the ARM change looks > good. My only request is to add a kernel option to turn on printing the > registers in the stack trace as it has been useful for tracking down > bugs. > I read the MD code of MIPS. seems it faces the same situation like arm (register pass parameter). I will follow its pattern to print out register. better than an option? > > Andrew > -- -Howard
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAvnz_qmn%2Ba%2B-aE4GkYw6TDOPzfST2j5WGvHqKX4WWVsVACSzQ>