Date: Tue, 16 Jun 2015 10:47:41 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Alexander Kabaev <kabaev@gmail.com> Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: Re: [rfc] fix umul_ppmm() in our libgcc Message-ID: <CAJ-Vmokm1anJUaZLEFpW=JpV5nec7CTuL1yPOJdZniQ53%2BArcQ@mail.gmail.com> In-Reply-To: <20150616011832.146e0f0e@kan> References: <CAJ-Vmonsmu5dGtWKhJchzZfSsVUjtwEVSEij4u6kwk64E0ZOXw@mail.gmail.com> <20150616011832.146e0f0e@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
ok, I'll give this a go tomorrow. -a On 15 June 2015 at 22:18, Alexander Kabaev <kabaev@gmail.com> wrote: > On Sat, 13 Jun 2015 15:41:34 -0700 > Adrian Chadd <adrian@freebsd.org> wrote: > >> Hi, >> >> our libgcc in -base is very .. old. It chokes when compiling for >> mips32. This patch seems to do the right thing. >> >> Does anyone have any positive/negative feedback? >> >> Thanks, >> >> >> -adrian > > Newer version of GCC use similar construct, but actual multiplication > is done using more correct selection of casts: > > UDItype __x = (UDItype) (USItype) (u) * (USItype) (v); > > I suggest you follow their lead. No objections otherwise. > > -- > Alexander Kabaev
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmokm1anJUaZLEFpW=JpV5nec7CTuL1yPOJdZniQ53%2BArcQ>