Date: Mon, 11 Sep 2017 11:01:52 +0800 From: Sepherosa Ziehau <sepherosa@gmail.com> To: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, erj@freebsd.org, Robert Watson <rwatson@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, Andrew Gallatin <gallatin@freebsd.org> Subject: ixl(4) RSS hash type Message-ID: <CAMOc5czdx206oahgRPNa_VcoRTGZsamfYC_PB84SgEXnuzv0fA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Hi all, I am on the way to cleanup the UDP_IPV4_EX bit. The only effective consumer of this undefined RSS hash type is ixl. So I took a bit close look at it, then I have several question about its hash type configuration: ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if RSS_IPV6_EX is set for "options RSS". RSS_IPV6_EX never meant IPV6 fragments: https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex ixl_ptype_to_hash(). As far as I understand, the decoded.outer_frag means "outer packet header indicates a fragment", which has nothing to do with the any of the IPV6_EX related bits: https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types I believe these all should be fixed. Thanks, sephe -- Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5czdx206oahgRPNa_VcoRTGZsamfYC_PB84SgEXnuzv0fA>