Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Oct 2020 17:38:56 -0700
From:      Kevin Oberman <rkoberman@gmail.com>
To:        Christian Weisgerber <naddy@mips.inka.de>
Cc:        "freebsd-gnome@FreeBSD.org" <freebsd-gnome@freebsd.org>
Subject:   Re: curl update to 7.73.0 breaks ABI?
Message-ID:  <CAN6yY1vjZ20Z1iLQeQ-mKVZXZmO0CjfU76x4%2BU1h%2BARhby_gAw@mail.gmail.com>
In-Reply-To: <slrnropbcc.1uhl.naddy@lorvorc.mips.inka.de>
References:  <CAN6yY1vUg3G2Nn7LQLuRbrxMtt0UMB5j_NFXaL8Dd=DcEenzHg@mail.gmail.com> <20201016234218.GA69749@in-addr.com> <slrnropbcc.1uhl.naddy@lorvorc.mips.inka.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 18, 2020 at 2:05 PM Christian Weisgerber <naddy@mips.inka.de>
wrote:

> On 2020-10-16, Gary Palmer <gpalmer@freebsd.org> wrote:
>
> > Check you have "COOKIES" and "ALTSVC" (I think) checked in the curl
> > options.  I had cookies disabled for some reason in one of my builds and
> > it resulted in Curl_get_line not being generated
>
> Since 7.73.0, all of lib/curl_get_line.c is behind this:
>
> #if !defined(CURL_DISABLE_COOKIES) && !defined(CURL_DISABLE_ALTSVC)
>
> --
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
>
Yes, but ALTSVC is set by default (and so is COOKIES) in the port and it is
still not built. (I had only ALTSVC, not COOKIES.) I have now built with
COOKIES and it works. Also tried COOKIES without ALTSVC and it also worked.

Not sure why the choice in the presentation of the #if. I'd demornganize it
for clarity.
#if defined(CURL_DISABLE_COOKIES) || defined(CURL_DISABLE_ALTSVC)

Still, it should be built and I don't understand why it's not! Does
Makefile syntax require parens around the full expression? That would
explain it.
--
Kevin Oberman, Part time kid herder and retired Network Engineer
E-mail: rkoberman@gmail.com
PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN6yY1vjZ20Z1iLQeQ-mKVZXZmO0CjfU76x4%2BU1h%2BARhby_gAw>