Date: Sat, 2 Jun 2018 09:03:04 -0600 From: Warner Losh <imp@bsdimp.com> To: Vladimir Kondratyev <vladimir@kondratyev.su> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Proper way to remove never used ioctls Message-ID: <CANCZdfoScVOooB%2Bm9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ@mail.gmail.com> In-Reply-To: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev <vladimir@kondratyev.su> wrote: > Hi, > > Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SETVARS > ioctls which are not documented and only stubbed in a few drivers: mse(4), > psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS > implemented in psm(4) > > Given the fact that they were introduced 20 years ago, implementation was > never completed and googling on them shows no traces of usage in indexed > universe, is it acceptable to just drop both defines and implementation > w.o. leaving any COMPAT_FREEBSD shims? I'd prepare a patch just removing them. I'd then send that patch to the ports mgr team and request a exp-run. Details for that can be found in https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html Once that's done, submit a Phabricator review and send me email. I'll make sure it gets pushed in if there's no objections. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoScVOooB%2Bm9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ>