Date: Mon, 8 May 2017 12:39:02 -0600 From: Warner Losh <imp@bsdimp.com> To: Vladimir Kondratyev <vladimir@kondratyev.su> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: psm(4) & atkbdc(4) locking Message-ID: <CANCZdfrvZ0OuQhRhcpMhxFphMjBuR22HJQTNyL=NDLb1VihJRQ@mail.gmail.com> In-Reply-To: <a50871663d281c388e16b146496ed035@kondratyev.su> References: <a50871663d281c388e16b146496ed035@kondratyev.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 8, 2017 at 12:33 PM, Vladimir Kondratyev <vladimir@kondratyev.su> wrote: > Hi All > > In order to implement evdev support in psm(4) driver I`m going to add > mutexes to psm and atkbdc drivers and mark psm interrupt and cdev handlers > MPSAFE. > Atkbd(4) is depending on Giant like before. > > Locking of these drivers seems to be low-hanging fruit as spl() calls are > still in place but it has not occurred. > > Does someone know why it is not done yet? For reasons other than "Nobody > took care of it"? > Any hidden traps? Working rock-solid reliably in ddb(4) is what tripped me up when I started down this path 10 years ago. Understanding all the rules for that was a bridge too far for me given the time I had for the project then. If you have that covered (I haven't looked at the diffs yet), you're golden. Warner > Patches can be found here: > https://reviews.freebsd.org/D10263 (atkbdc, serialize hw registers access) > https://reviews.freebsd.org/D10264 (psm, serialize softc access, mark > interrupt and cdev handlers MPSAFE) > > -- > WBR > Vladimir Kondratyev > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrvZ0OuQhRhcpMhxFphMjBuR22HJQTNyL=NDLb1VihJRQ>